RT hits and the lit shader let a lamp's own fixture shadow its light #1041

Open
opened 2026-10-25 03:56:05 +00:00 by sky_line · 1 comment
Owner

The own-fixture rule (#439 / #869: a point light's own lamp shade does not shadow or tint its light) exists only in the generic shadow core (clean_shadow_core.glsl). The other walk, traceShadowWalk, doesn't have it, so in ray-traced reflections, GI hits and the forward lit shader a lamp's shade can shadow its own light.

Found by the #1039 design survey (copies of the same code that have drifted apart). The shared walk library planned as #1039 step M0 removes the duplicate.

The own-fixture rule (#439 / #869: a point light's own lamp shade does not shadow or tint its light) exists only in the generic shadow core (clean_shadow_core.glsl). The other walk, traceShadowWalk, doesn't have it, so in ray-traced reflections, GI hits and the forward lit shader a lamp's shade can shadow its own light. Found by the #1039 design survey (copies of the same code that have drifted apart). The shared walk library planned as #1039 step M0 removes the duplicate.
sky_line added this to the Slipstream project 2026-10-25 03:56:05 +00:00
Author
Owner

Fixed in 1.5.0 Beta 1 (9c8581cab0). Reopen if you still see it.

Fixed in 1.5.0 Beta 1 (9c8581cab0). Reopen if you still see it.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
sky_line/Slipstream#1041
No description provided.