RT hits and the lit shader let a lamp's own fixture shadow its light #1041
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Depends on
Reference
sky_line/Slipstream#1041
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The own-fixture rule (#439 / #869: a point light's own lamp shade does not shadow or tint its light) exists only in the generic shadow core (clean_shadow_core.glsl). The other walk, traceShadowWalk, doesn't have it, so in ray-traced reflections, GI hits and the forward lit shader a lamp's shade can shadow its own light.
Found by the #1039 design survey (copies of the same code that have drifted apart). The shared walk library planned as #1039 step M0 removes the duplicate.
Fixed in 1.5.0 Beta 1 (
9c8581cab0). Reopen if you still see it.