Snapshots larger than the window are slightly blurry since #932 (no sharpening after the accumulation) #1093
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream#1093
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Users report snapshots a little blurrier in recent versions. Confirmed by a reporter's test: snapshots at the current window size are sharp; snapshots at other sizes (larger than the window) are soft.
Investigation (research/SNAPSHOT_BLUR.md, local): sizes above the window go through the jittered live accumulation (#873). The #932 grain fix (
8abf303470) turned CAS sharpening off on the jittered samples (llcleanrenderervk.cpp~30566,lens2[2] = 0while capturing) and nothing sharpens the accumulated result instead; before #932 per-sample CAS partly offset the accumulator's softening. Contributing: the Gaussian reconstruction width (kAccSigma0.5 output px), a fixed -0.5 texture mip bias while supersampling (2x wants about -1, 4x about -2), and bilinear-class gamma-space CPU scale-ups in the reduced-render fallbacks.Fix without bringing back #932's grain: sharpen the accumulated mean once (linear light, before the output dither, strength from RenderCASSharpness), density-aware reconstruction width or a sharper kernel, mip bias by supersampling factor while a shot accumulates, Lanczos in linear light for the CPU scale-ups.