First unit test suites: pure-logic modules with high regression risk #1245
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream#1245
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Part of #1243.
Scope. Prerequisite: a viewer-free home for testable logic. Many of these modules live in
newviewbehindllviewerprecompiledheaders.hand viewer globals, so they cannot be linked into a small test executable. Createindra/slcore(static library, depends only on llcommon, llmath, llxml, llinventory, llcachestore) and move or split the pure parts into it, leaving thin forwarders in newview. This is the same refactor the fuzzing README proposes for the SLBridge line parser and the weather tag parser. Suites, in priority order (each is its own sub-task and its own test executable):SLWeathermixing / quantisation;SLWeatherRegion::parseTag/formatTag/tagRoundTrips/editDescription(move toslweathertag.cpp; round-trip property tests plus the failure corpus from fuzzing).llcachestore,slcachestore,slassetcachestore, migrations): already has integration tests (llcachestore,llfilesystemstore,slgputexmigrate,slj2cmigrate,slassetmigrate); port those and add: crash-in-the-middle recovery, byte-budget eviction (feedback rule "every cache frees or has a budget"), corrupted record skipped not fatal.LLInventoryItem::importLegacyStreamround trips (use thefuzz_inventorycorpus as extra fixtures).llkeybind, the settings migration code): golden input files for v2, v3, partially corrupt, and user-edited, asserting no binding is lost or duplicated.SLBridgeLine::parse(prefix, type,|fields, hello handshake fields, over-long and malformed lines) once extracted fromprocessOwnerSay; token-bucket route budget as a pure function.llsdserialize_testis the starting point.Acceptance criteria.
indra/slcoreexists, builds under GCC and clang-cl, has no dependency onnewview, GL or Vulkan.slowand moved out of the default run.Effort. Large: 1 to 2 weeks for
slcoreextraction plus suites 1 to 4, about 1 week more for 5 to 8; suites 7 and 8 are small. Do 1, 5 and 7 first (highest risk per line, lowest extraction cost).