Sanitizer CI: periodic ASan + UBSan build and smoke run, off the release path #1248
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream#1248
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Part of #1243.
Scope. The tree has no sanitizer configuration (
USE_ASANonly adds-Og; nothing passes-fsanitize). Add real ones and run them regularly on a box that is not on the release path.SL_SANITIZEoption (address,undefined,address;undefined,threadas a separate non-default), with presetslinux-asan(clang or GCC,-fno-omit-frame-pointer,-O1,-g) andlinux-ubsan, own binary dirs,-fno-sanitize=alignmentplus the suppression file (indra/fuzz/ubsan.supppattern), never combined withLL_FUZZorwindows-cross. Reuseindra/cmake/LLFuzz.cmakeflag logic rather than a second copy.ASAN_OPTIONS=protect_shadow_gap=0(NVIDIA driver maps into the shadow gap),detect_leaks=0initially (LL's lazily grown tables), the existing "ASan VK build" notes in the maintainer's reference; vulkan loader interposition (LD_PRELOAD-free: link ASan runtime first); the shader-binary cache must be deleted per run (memory note: stale.shaderbin).linux-asanon applejack, run the default unit suite plus the fuzz replay tests under it (cheap, catches memory errors in all unit-tested modules).TESTCTL=1, runmake validate SCENARIO=core(login, teleport, rez, close) with a 3x timeout multiplier, collect the ASan reports as artifacts. A cleancorerun is the bar;syncis optional.corescenario.sanitizer; known benign ones go in the suppression file with a comment and a ticket reference.release.yml, no tag triggers it, failures never block a beta; the release checklist only asks that nosanitizer-labelled P1 is open.Acceptance criteria.
cmake --preset linux-asan && cmake --build --preset linux-asanproduces a working sanitised viewer binary and unit test executables; documented indoc/DEVELOPER_GUIDE.md.Effort. About 2 to 3 days for presets and the CI workflow; open-ended triage of the first findings (budget 2 days, spill into separate tickets). Risk: the viewer's 2.8 GB debug-info binary under ASan is slow to link and large; use
-gline-tables-onlyfor the sanitised build.