Blend layers with RenderVKBlendHitLighting: blocky dark mosaic where the GI cache has no cells #1499
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream#1499
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
A semi-transparent cloud mesh (legacy, tint alpha 0.87, under a house in a sky region) gets a blocky light/dark mosaic and a dark band on its underside with
RenderVKBlendHitLightingon (default). Off, it is smooth.A/B on the live viewer:
RenderVKBlendHitLighting0: smooth, brightRenderVKGI0: smooth, brightRenderVKGIHitAmbient0: still blockyRenderVKGICache0: no mosaic, but the whole underside nearly black (~42 vs ~168)RenderVKGIDebug6: the cache covers the underside in patches (red = no cell), matching the mosaicCause (clean_surface_light.glsl,
giForwardRefl/blendHitEnvunderCLEAN_BLEND_HIT): where the cells around P have no estimate, the fallback ambient is the probes xg_bh_occ, the one occlusion ray along the reflection direction R. Seen from below, R points at the ground, sog_bh_occis 0 and those spots get no ambient at all, right next to cells that do have the cache's light.The mirror-direction ray suits the specular share, but the diffuse fallback on a face looking down at sunlit ground probably shouldn't hang on it.
Workaround:
RenderVKBlendHitLighting0.Possible fixes (the uncovered share's diffuse fallback; the specular can keep the R ray):
giFwdScreenOcc), as the non-blend-hit path does: no extra ray, and the sealed-room glass case (fix-blend-ambient-occlusion, the blend-gi-occ check) still holds where the pixel behind is enclosed.