#1557: FSR 3.1 / DLSS are the only temporal anti-aliasing; our TAA resolve is gone #1558

Closed
TheSlowly wants to merge 0 commits from TheSlowly/Slipstream:remove-taa into main
Collaborator

Closes #1557, closes #1431. Our own TAA resolve (clean_taa.comp) is deleted: FSR 3.1 (or DLSS where picked) is the only temporal resolve.

  • Antialiasing (Preferences, Photo Studio) offers None / FXAA / SMAA; temporal AA is an upscaler mode: FSR Native AA, DLSS DLAA, or a scaled preset. Defaults are unchanged.
  • TAA users move once at startup: DLAA where DLSS is available, else FSR Native AA; Antialiasing becomes SMAA. An old preset's TAA value arriving later runs as FSR Native AA (SMAA where FSR cannot run).
  • One rule (llupscalermode.h, host-tested) decides the mode the renderer runs; the renderer reads RenderVKUpscaler only through it.
  • Deleted: the resolve, its history (about 150 MB at 4K under DLSS / FSR), RenderVKTAADebug, RenderVKTAAStability, RenderVKGlowTemporalLowRes. The temporal plumbing FSR / DLSS read stays.
  • Glow on FSR / DLSS frames: the render-resolution glow temporal only (no display-size glow-only TAA pass). A/B in world: it looks better than the raw glow even at Ultra Performance, so it stays (RenderVKTAAGlow).
  • FSR not running: a single failed frame renders without a temporal resolve; 3 in a row, or a device that cannot run FSR, render native without jitter (FXAA / SMAA) until the mode or window size changes, logged once. RenderVKFSRDebugFailPrepare forces it. A DLSS mode whose DLSS stands down with FSR unusable renders native too.
  • Shorter upscaling tooltip; graphics combos say "Automatic" instead of "Auto" (Ray Reconstruction, texture / video memory, weather), as the rest of Preferences does. Renderer comments no longer describe a TAA resolve.
  • New check taa-removed; test plan doc/testplans/1557-remove-taa.md.

Tested in world (Windows, RTX 5070 Ti): FSR Native AA / Quality / Performance / Ultra Performance, DLSS RR Quality / Performance, live mode switches, glow A/B, forced FSR failure (fallback frame, the give-up, recovery on a mode change), a late RenderFSAAType 3 with the upscaler off (FSR Native AA runs), frame generation 2x.

Not tested: the startup move itself in world (host-tested), Linux, AMD / Intel GPUs, a device without FSR support, VR.

Closes #1557, closes #1431. Our own TAA resolve (`clean_taa.comp`) is deleted: FSR 3.1 (or DLSS where picked) is the only temporal resolve. - Antialiasing (Preferences, Photo Studio) offers None / FXAA / SMAA; temporal AA is an upscaler mode: FSR Native AA, DLSS DLAA, or a scaled preset. Defaults are unchanged. - TAA users move once at startup: DLAA where DLSS is available, else FSR Native AA; Antialiasing becomes SMAA. An old preset's TAA value arriving later runs as FSR Native AA (SMAA where FSR cannot run). - One rule (`llupscalermode.h`, host-tested) decides the mode the renderer runs; the renderer reads `RenderVKUpscaler` only through it. - Deleted: the resolve, its history (about 150 MB at 4K under DLSS / FSR), `RenderVKTAADebug`, `RenderVKTAAStability`, `RenderVKGlowTemporalLowRes`. The temporal plumbing FSR / DLSS read stays. - Glow on FSR / DLSS frames: the render-resolution glow temporal only (no display-size glow-only TAA pass). A/B in world: it looks better than the raw glow even at Ultra Performance, so it stays (`RenderVKTAAGlow`). - FSR not running: a single failed frame renders without a temporal resolve; 3 in a row, or a device that cannot run FSR, render native without jitter (FXAA / SMAA) until the mode or window size changes, logged once. `RenderVKFSRDebugFailPrepare` forces it. A DLSS mode whose DLSS stands down with FSR unusable renders native too. - Shorter upscaling tooltip; graphics combos say "Automatic" instead of "Auto" (Ray Reconstruction, texture / video memory, weather), as the rest of Preferences does. Renderer comments no longer describe a TAA resolve. - New check `taa-removed`; test plan `doc/testplans/1557-remove-taa.md`. Tested in world (Windows, RTX 5070 Ti): FSR Native AA / Quality / Performance / Ultra Performance, DLSS RR Quality / Performance, live mode switches, glow A/B, forced FSR failure (fallback frame, the give-up, recovery on a mode change), a late `RenderFSAAType` 3 with the upscaler off (FSR Native AA runs), frame generation 2x. Not tested: the startup move itself in world (host-tested), Linux, AMD / Intel GPUs, a device without FSR support, VR.
llups::effectiveMode: a legacy RenderFSAAType 3 runs as FSR Native AA, an upscaler nothing can run is off.
llups::migrate: TAA users move to DLAA where DLSS is available, else FSR Native AA; Antialiasing becomes SMAA.
Host-tested by the new taa-removed check.
LLCleanRendererVK::upscalerMode (llups::effectiveMode) is the renderer's only view of RenderVKUpscaler:
taaRequested, fsrRequested, dlssModeSelected, renderScaleWanted and the FSR probe label read it. An FSR preset
on a device that cannot run FSR is off (native, no jitter) instead of the TAA upscaler; a legacy
RenderFSAAType 3 runs as FSR Native AA.

FSR whose prepare fails 3 frames running is given up on until the upscaler mode or the window size changes
(logged once each way). RenderVKFSRDebugFailPrepare forces the failure for testing.
migrateTaaToUpscaler runs right after LLVulkanContext::init (DLSS availability is known): RenderFSAAType 3 or
the old RenderVKTAA switch move to DLAA where DLSS is available, else FSR Native AA (an upscaler already
chosen is kept); Antialiasing 3 becomes SMAA. RenderVKTAA stays as a hidden key for this and the usage
statistics.
clean_taa.comp, recordTAA, the TAA history (two RGBA16F images + weights at the display size) and its sets,
pipeline and param-ring region are deleted, with RenderVKTAADebug, RenderVKTAAStability and
RenderVKGlowTemporalLowRes. Closes #1431 (the history allocated under DLSS / FSR).

- ensureTemporalResolve decides mTaaNow (an FSR / DLSS frame with every input present) and allocates nothing.
- Glow on FSR / DLSS frames: always the render-resolution glow temporal (recordGlowResolve), never a
  display-size glow-only TAA dispatch; ensureGlowTemporal owns the pair and its sets.
- A frame meant for FSR where FSR did not run renders without a temporal resolve (recordResolveFallback:
  mTaaNow cleared so later passes take their non-temporal path; a scaled frame is blitted).
- The glow temporal and sharpening pipelines are built on their own (FSR / DLSS still test mRcasPipe);
  sharpening keeps one set (the SSR copy).
- Snapshot supersampling has its own GPU timer (p_snapacc).
The Antialiasing lists (Preferences, Photo Studio) drop TAA: None / FXAA / SMAA, with the upscaler list
(FSR Native AA, DLSS DLAA, scaled presets) as the temporal choice. Tooltips, the bug report, the perf capture
and the GPU-lost settings line follow; FSR's "unavailable" log line and comments no longer name a TAA
fallback. Test plan doc/testplans/1557-remove-taa.md.
The jitter follows llups::temporalRuns (DLSS this frame, or FSR able to run the matching preset) and the
render scale off DLSS follows llups::fsrTier (native when FSR cannot run). A legacy RenderFSAAType 3 that
cannot run as FSR Native AA gets SMAA (llups::postAaType), never no anti-aliasing.
- A frame DLSS resolves resets the FSR failure count (3 failures running = consecutive).
- fsrUsable caches the device answer only with a device context.
- The give-up and fallback log lines name what a DLSS mode does (DLSS keeps running; neither ran).
- Renderer comments that still described a TAA resolve now name FSR / DLSS or the temporal resolve.
Ray Reconstruction, texture memory, video memory and weather quality offer "Automatic" (and their
tooltips say so), as the rest of Preferences does. (The Linux display backend list keeps "Auto": its
combo is too narrow for the longer word.)
Author
Collaborator

Merged to main in a3770ff88a; closing.

Merged to main in a3770ff88a; closing.
TheSlowly closed this pull request 2026-11-18 01:32:08 +00:00

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sky_line/Slipstream!1558
No description provided.