Skins: harden Add skin and import skins from other viewers (convert colours/textures, validate or skip incompatible XUI, safe unpack) #1599
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream#1599
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Today, Preferences > Skins > Add skin (inherited from Alchemy:
LLFloaterPreference::onAddSkinCallback) only takes a.zipwith amanifest.jsoncarrying a"name". It unpacks it blindly into the userskins/folder. There is no validation, no way to import from another viewer's install, and a skin whose XUI files don't match ours can break or hide parts of the UI.Harden the existing path
.., absolute paths, symlinks) and files outside the expected skin layout;manifest.jsonis no longer fatal for a folder or zip that otherwise looks like a skin; generate one from the folder name. Also read the optional fields: author, version, viewer.Expand: import from other viewers
skins/folders and user skin folders, per OS);Compatibility: convert or ignore bad entries
colors.xml): import every colour name we use, and drop or warn about names we don't. Map the known renamed colours between viewers (a small alias table).textures/+textures.xml): import the images for texture names we use, and drop unknown ones. Check formats and sizes. A missing or invalid image falls back to ours, never a blank.getChild/findChildnames in the matching panel or floater). Files that fail are skipped and listed. Files that pass load as overrides, as now.skin_settings.xml: import only known keys; ignore unknown ones.Done when