GI: fresh ray directions are white noise (the R2 sequence has no effect) #1611
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream#1611
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
giFreshRay(clean_deferred_light.comp) seeds its per-texel hash with the frame number and then adds the R2 step for that frame. Because the seed already changes every frame, each frame's ray direction is independent white noise and the R2 term does nothing, so a texel's rays don't cover its hemisphere evenly over time and GI history converges slower than it should.Fix: hash the texel only (a fixed per-texel rotation) and step R2 by frame, in 32-bit fixed point, the way
rtrLobeDiralready does for RT reflections.Found in a read-through of the denoising / noise paths.
Shipped in 1.6.0 Beta 4.