GI denoiser reads its history half a texel off (ignores last frame's jitter) #1614

Closed
opened 2026-11-18 15:43:24 +00:00 by TheSlowly · 1 comment
Collaborator

The GI denoiser's temporal pass maps motion vectors to last frame's unjittered position, but the history was traced on last frame's jittered sample lattice over a jittered image. Every history read is up to half a texel off (clean_dn_temporal.comp, the reprojection; GI doesn't set sampleGridHistory). Result: a sub-texel resample every frame (softer GI) and edge taps that pass or fail the geometry tests with the jitter (shimmer), at full resolution too. The stochastic shadow denoiser already corrects this.

From #1613. The default lag fetch (clean_deferred_light.comp deferGiFetchLag) has the same offset and stays a follow-up.

The GI denoiser's temporal pass maps motion vectors to last frame's *unjittered* position, but the history was traced on last frame's jittered sample lattice over a jittered image. Every history read is up to half a texel off (clean_dn_temporal.comp, the reprojection; GI doesn't set sampleGridHistory). Result: a sub-texel resample every frame (softer GI) and edge taps that pass or fail the geometry tests with the jitter (shimmer), at full resolution too. The stochastic shadow denoiser already corrects this. From #1613. The default lag fetch (clean_deferred_light.comp deferGiFetchLag) has the same offset and stays a follow-up.
TheSlowly added this to the Slipstream project 2026-11-18 15:43:24 +00:00
Owner

Shipped in 1.6.0 Beta 4.

Shipped in 1.6.0 Beta 4.
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sky_line/Slipstream#1614
No description provided.