#1572: Camera mode on the new interface kit #1621
No reviewers
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream!1621
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "TheSlowly/Slipstream:camera-kit-1572"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Part of #1572: camera mode's overlay (#1573, #1576–#1579, presets #1231) rebuilt as one RmlUi document on the new interface kit, plus saving to inventory, profile and e-mail.
slcameraview.cpp) over a UI-free model (slcameramodel.cpp) replaces the hand-drawn overlay. The input decisions are tested (camera-input,camera-bar-layout), the document by a newcamera-rmlcheck.UIRenderermode; the classic snapshot window opens only if RmlUi cannot start.UIKitTheme(0 dark, 1 light), read by camera mode only for now.Design:
doc/camera-mode-design.md. Test plan:doc/testplans/1572-camera-mode.md. Played in-world withUIRenderer0 and the dark theme. Not run yet:UIRenderer1 and 2, the light theme, and the inventory / profile / e-mail uploads.Moving the presets into the rail left one closing tag of their old popover behind. It ended the data-model element early, so the rest of the overlay showed raw {{bindings}} with every panel open. RmlUi says nothing about unbalanced markup, so a new check (camera-rml) reads the document out of the source and requires balanced tags, everything inside the one data model, and every {{variable}} and data-* expression bound.Merged into main in
fedb692509; closing.Pull request closed