Hidden HUDs (Ctrl+Alt+H) can still be clicked #187
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream#187
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Steps: wear a HUD, press Ctrl+Alt+H (hide HUD attachments). The HUDs disappear, but clicking where they were still clicks them (touches, menus, hover cursor).
Expected: hidden HUDs can't be clicked or hovered (as in the official viewer / Firestorm).
Cause (found while filing): under Vulkan,
LLPipeline::lineSegmentIntersectInHUD(pipeline.cpp ~2640) returnsvkPickHUD(...)straight away; nothing on that path checksLLPipeline::sShowHUDAttachments. The GL path only reached HUD drawables through the HUD spatial partition, which isn't populated/visible while HUDs are hidden, so it never needed an explicit check. The HUD render pass does check it (llappviewer.cpp~4931: HUD view-proj only passed when shown), so rendering and picking disagree.Fix: return no hit from the VK HUD pick while
!sShowHUDAttachments. Also check the other HUD-pick entry points that bypasslineSegmentIntersectInHUD(e.g.cursorIntersectwith a specificthis_objectthat is a HUD attachment -- llviewerwindow.cpp ~4980 -- hover / right-click on a remembered object) and HUD hover text / selection beams on hidden HUDs. RLVa: hiding stays blocked while a locked HUD is worn (llviewermenu.cpp ~9980), unchanged.