Reflection probes make interiors / probed houses darker than expected (RT capture darker still) #250
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream#250
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Report
A house covered by manual reflection probes (one large probe bigger than the house, or one probe per floor) looks darker than it should with probes than without. Both capture modes show it, and ray-traced capture (Reflection Detail 3) is a little darker than raster capture.
The user's hypothesis is that the captures don't collect exterior light even though the probe volume is larger than the house.
How probes work (as LL defines them)
These are the points to check our implementation against.
clean_rt_shade.glsl) uses sky ambient irradiance, and its sun visibility is a single hard ray. That may explain RT being darker.reflection_probe_ambiance, plusRenderSkyAutoAdjustProbeAmbiance/ HDR auto-adjust) scales probe ambient. Skies with low ambiance give dark probe-lit interiors in LL too. Check our VK path applies the same scale.Viewers really do disagree on this. Firestorm / LL / Alchemy-GL differ in auto-adjust and ambiance handling, so this needs a defined target rather than parity alone.
Investigate
reflection_probe_ambianceand auto-adjust are applied in VK vs LL.Possible improvements beyond parity
These follow standard practice:
Related
#249 (probe boxes at zoom), the probe P1/P2 visibility work (normal rejection + Chebyshev occlusion can also darken).