Windows: Authenticode code signing for the viewer and installer (SmartScreen / AV) #287
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream#287
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Our Windows builds are unsigned: SmartScreen shows "Windows protected your PC" (users must click More info > Run anyway), some antivirus tools flag or quarantine unsigned installers, and users have no way to verify a download came from us. Related: #286 (Flatpak signing), Linux signing ticket.
What to sign
SlipstreamViewer.exe/slipstream-bin.exeand our own DLLs, the NSISSetup.exe(and its uninstaller), and the bundled CEF/dullahan helper executables where we ship our own builds. Third-party DLLs already signed by their vendor stay as they are.Certificate options
CI integration (applejack cross-builds Windows on Linux)
osslsigncode(PKCS#11 for an HSM/token, or a cloud signing API), or call Azure Trusted Signing's REST/jsign(jsign supports Trusted Signing, Azure Key Vault and PKCS#11 tokens, and runs on Linux, a good match for our cross-build).osslsigncode verifyin CI and fail the release if verification fails.Also
Linux counterpart: #288. Flatpak: #286.