LL perf (Objects/world): `removeFromMap` is linear find plus vector erase per killed object #316

New issue

Closed

opened 2026-10-04 14:09:18 +00:00 by sky_line · 0 comments

sky_line commented

2026-10-04 14:09:18 +00:00

Owner

From the LL-origin inefficiency audit (finding O9). File/line references are from commit 0229f8872c; re-locate them before working.

removeFromMap is linear find plus vector erase per killed object

Where: llviewerobjectlist.h:313-320, called from cleanupReferences (.cpp:1425-1428).
Cost: O(K·N) on region drop or a KillObject storm.
Fix: stored index plus swap-and-pop (as removeFromActiveList does at :1585-1609).
Confirmed. S.

Verify the cost (profile or timer) before and after changing it.

From the LL-origin inefficiency audit (finding O9). File/line references are from commit 0229f8872c; re-locate them before working. **`removeFromMap` is linear find plus vector erase per killed object** - **Where:** `llviewerobjectlist.h:313-320`, called from `cleanupReferences` (`.cpp:1425-1428`). - **Cost:** O(K·N) on region drop or a KillObject storm. - **Fix:** stored index plus swap-and-pop (as `removeFromActiveList` does at `:1585-1609`). - Confirmed. S. Verify the cost (profile or timer) before and after changing it.

sky_line added the

perf

label

2026-10-04 14:09:18 +00:00

sky_line referenced this issue from a commit

2026-10-05 08:37:46 +00:00

Object list: O(1) removeFromMap via stored index and swap-and-pop

sky_line closed this issue

2026-10-05 08:37:46 +00:00

sky_line referenced this issue

2026-10-05 11:52:46 +00:00

Post-teleport hitch when old regions drop: ~7.8k objects torn down in single frames -- time-slice / batch region teardown #433