LL perf (Objects/world): `LLObjectSignaledAnimationMap` never erases #318

New issue

Closed

opened 2026-10-04 14:09:18 +00:00 by sky_line · 0 comments

sky_line commented

2026-10-04 14:09:18 +00:00

Owner

From the LL-origin inefficiency audit (finding O11). File/line references are from commit 0229f8872c; re-locate them before working.

LLObjectSignaledAnimationMap never erases

Where:
- getMap()[uuid] inserts before the existence check (llviewermessage.cpp:4493).
- LLControlAvatar::updateAnimations inserts an entry for every animesh prim (llcontrolavatar.cpp:576).
- No erase anywhere in the tree.
Fix: find; erase in markDead.
Small extra: llformat("Vol%p") regardless of log level (llviewerobject.cpp:3220, 3226).
Confirmed. S. LL: same.

Verify the cost (profile or timer) before and after changing it.

From the LL-origin inefficiency audit (finding O11). File/line references are from commit 0229f8872c; re-locate them before working. **`LLObjectSignaledAnimationMap` never erases** - **Where:** - `getMap()[uuid]` inserts before the existence check (`llviewermessage.cpp:4493`). - `LLControlAvatar::updateAnimations` inserts an entry for every animesh prim (`llcontrolavatar.cpp:576`). - No erase anywhere in the tree. - **Fix:** `find`; erase in `markDead`. - **Small extra:** `llformat("Vol%p")` regardless of log level (`llviewerobject.cpp:3220, 3226`). - Confirmed. S. LL: same. Verify the cost (profile or timer) before and after changing it.

sky_line added the

perf

label

2026-10-04 14:09:18 +00:00

sky_line referenced this issue from a commit

2026-10-05 08:37:46 +00:00

Control avatar: look up signaled animations with find() instead of operator[]

sky_line added this to the Slipstream project

2026-10-06 15:04:13 +00:00

sky_line added the

status

testing