LL perf (Avatar/animation): `updateVisualParams` walks every parameter, and morphs run for invisible body parts #329

New issue

Closed

opened 2026-10-04 14:09:21 +00:00 by sky_line · 1 comment

sky_line commented

2026-10-04 14:09:21 +00:00

Owner

From the LL-origin inefficiency audit (finding A4). File/line references are from commit 0229f8872c; re-locate them before working.

updateVisualParams walks every parameter, and morphs run for invisible body parts

Callers: physics, LLEmote (every frame while active, plus a getVisualParam("Express_Closed_Mouth") string lookup, llemote.cpp:107-116), hand blending, lip sync.
The walk: getVisualParamWeight("male") does a string copy, lowercase and string-table hash (llcharacter.cpp:339-348), then a full mVisualParamIndexMap walk (:470-487).
Wasted morphs: LLPolyMorphTarget::apply morphs system-body verts even when the BOM layer is invisible under a mesh body (llpolymorph.cpp:569-652) and bumps mMorphGen, which triggers a re-upload.
Fix: dirty-param list; cache param pointers; skip vertex morphs for invisible parts but keep volume morphs.
Likely. M.

Verify the cost (profile or timer) before and after changing it.

From the LL-origin inefficiency audit (finding A4). File/line references are from commit 0229f8872c; re-locate them before working. **`updateVisualParams` walks every parameter, and morphs run for invisible body parts** - **Callers:** physics, `LLEmote` (every frame while active, plus a `getVisualParam("Express_Closed_Mouth")` string lookup, `llemote.cpp:107-116`), hand blending, lip sync. - **The walk:** `getVisualParamWeight("male")` does a string copy, lowercase and string-table hash (`llcharacter.cpp:339-348`), then a full `mVisualParamIndexMap` walk (`:470-487`). - **Wasted morphs:** `LLPolyMorphTarget::apply` morphs system-body verts even when the BOM layer is invisible under a mesh body (`llpolymorph.cpp:569-652`) and bumps `mMorphGen`, which triggers a re-upload. - **Fix:** dirty-param list; cache param pointers; skip vertex morphs for invisible parts but keep volume morphs. - Likely. M. Verify the cost (profile or timer) before and after changing it.

sky_line added the

perf

label

2026-10-04 14:09:21 +00:00

sky_line added this to the Slipstream project

2026-10-06 15:04:14 +00:00

sky_line added the

status

in-progress

label

2026-10-08 02:07:15 +00:00

sky_line referenced this issue from a commit