LL perf (Avatar/animation): Keyframe curves are `std::map<F32,Key>`; the loop-in wrap branch is dead #332

New issue

Closed

opened 2026-10-04 14:09:22 +00:00 by sky_line · 1 comment

sky_line commented

2026-10-04 14:09:22 +00:00

Owner

From the LL-origin inefficiency audit (finding A8). File/line references are from commit 0229f8872c; re-locate them before working.

Keyframe curves are std::map<F32,Key>; the loop-in wrap branch is dead

Where: llkeyframemotion.h:346/365/384; .cpp:169/249/330.
Dead branch: right == mKeys.end() inside the between-keys branch can never be true (:189/269/350).
Fix: sorted SoA arrays plus a cached last index; implement the wrap.
Confirmed. M.

Verify the cost (profile or timer) before and after changing it.

From the LL-origin inefficiency audit (finding A8). File/line references are from commit 0229f8872c; re-locate them before working. **Keyframe curves are `std::map<F32,Key>`; the loop-in wrap branch is dead** - **Where:** `llkeyframemotion.h:346/365/384`; `.cpp:169/249/330`. - **Dead branch:** `right == mKeys.end()` inside the between-keys branch can never be true (`:189/269/350`). - **Fix:** sorted SoA arrays plus a cached last index; implement the wrap. - Confirmed. M. Verify the cost (profile or timer) before and after changing it.

sky_line added the

perf

label

2026-10-04 14:09:22 +00:00

sky_line added this to the Slipstream project

2026-10-06 15:04:14 +00:00

sky_line added the

status

in-progress

label

2026-10-08 02:07:15 +00:00

sky_line referenced this issue from a commit