LL perf (Avatar/animation): `updateMotionsByType` walks the std::list twice with a virtual `getBlendType()` per pass; `remove()` is O(n) #334

New issue

Closed

opened 2026-10-04 14:09:22 +00:00 by sky_line · 1 comment

sky_line commented

2026-10-04 14:09:22 +00:00

Owner

From the LL-origin inefficiency audit (finding A10). File/line references are from commit 0229f8872c; re-locate them before working.

updateMotionsByType walks the std::list twice with a virtual getBlendType() per pass; remove() is O(n)

Where: llmotioncontroller.cpp:779-795, 333, 1039, 1076.
Fix: split lists or a vector with stored indices.
Confirmed. S-M.

Verify the cost (profile or timer) before and after changing it.

From the LL-origin inefficiency audit (finding A10). File/line references are from commit 0229f8872c; re-locate them before working. **`updateMotionsByType` walks the std::list twice with a virtual `getBlendType()` per pass; `remove()` is O(n)** - **Where:** `llmotioncontroller.cpp:779-795, 333, 1039, 1076`. - **Fix:** split lists or a vector with stored indices. - Confirmed. S-M. Verify the cost (profile or timer) before and after changing it.

sky_line added the

perf

label

2026-10-04 14:09:22 +00:00

sky_line added this to the Slipstream project

2026-10-06 15:04:14 +00:00

sky_line added the

status

in-progress

label

2026-10-08 02:07:15 +00:00

sky_line referenced this issue from a commit