LL perf (Inventory): `notifyObservers` has no early-out; friend packets force notifies; the categories observer rehashes every watched outfit on any LABEL change #341

New issue

Closed

opened 2026-10-04 14:09:24 +00:00 by sky_line · 1 comment

sky_line commented

2026-10-04 14:09:24 +00:00

Owner

From the LL-origin inefficiency audit (finding I5). File/line references are from commit 0229f8872c; re-locate them before working.

notifyObservers has no early-out; friend packets force notifies; the categories observer rehashes every watched outfit on any LABEL change

Where: llinventorymodel.cpp:2242-2285, llcallingcard.cpp:701-757, llinventoryobserver.cpp:670-750.
Why LABEL fires constantly: addCOFItemLink always adds LABEL (llappearancemgr.cpp:3363).
Fix: early return; drop the notify in processNotify; intersect changed ids with the watched set.
Confirmed. S-M.

Verify the cost (profile or timer) before and after changing it.

From the LL-origin inefficiency audit (finding I5). File/line references are from commit 0229f8872c; re-locate them before working. **`notifyObservers` has no early-out; friend packets force notifies; the categories observer rehashes every watched outfit on any LABEL change** - **Where:** `llinventorymodel.cpp:2242-2285`, `llcallingcard.cpp:701-757`, `llinventoryobserver.cpp:670-750`. - **Why LABEL fires constantly:** `addCOFItemLink` always adds LABEL (`llappearancemgr.cpp:3363`). - **Fix:** early return; drop the notify in `processNotify`; intersect changed ids with the watched set. - Confirmed. S-M. Verify the cost (profile or timer) before and after changing it.

sky_line added the

perf

label

2026-10-04 14:09:24 +00:00

sky_line added this to the Slipstream project

2026-10-06 15:04:14 +00:00

sky_line added the

status

in-progress

label

2026-10-08 02:07:12 +00:00

sky_line referenced this issue from a commit