LL perf (Inventory): `changeItemParent`: per item #342

New issue

Closed

opened 2026-10-04 14:09:24 +00:00 by sky_line · 1 comment

sky_line commented

2026-10-04 14:09:24 +00:00

Owner

From the LL-origin inefficiency audit (finding I6). File/line references are from commit 0229f8872c; re-locate them before working.

changeItemParent: per item

Per item: one MoveInventoryItem, one heap copy, a full notifyObservers, and 3 INFO log lines with O(depth²) path building (llinventorymodel.cpp:1834-1859; llinventoryfunctions.cpp:226-273).
Callers: 22 sites, including multi-item drag-drop and move-to-trash.
Shows it can batch: the message supports multiple blocks; removeBatchNoCheck already batches.
Fix: changeItemsParent(vector); DEBUG logs.
Confirmed. M.

Verify the cost (profile or timer) before and after changing it.

From the LL-origin inefficiency audit (finding I6). File/line references are from commit 0229f8872c; re-locate them before working. **`changeItemParent`: per item** - **Per item:** one `MoveInventoryItem`, one heap copy, a full `notifyObservers`, and **3 INFO log lines with O(depth²) path building** (`llinventorymodel.cpp:1834-1859`; `llinventoryfunctions.cpp:226-273`). - **Callers:** 22 sites, including multi-item drag-drop and move-to-trash. - **Shows it can batch:** the message supports multiple blocks; `removeBatchNoCheck` already batches. - **Fix:** `changeItemsParent(vector)`; DEBUG logs. - Confirmed. M. Verify the cost (profile or timer) before and after changing it.

sky_line added the

perf

label

2026-10-04 14:09:24 +00:00

sky_line added this to the Slipstream project

2026-10-06 15:04:13 +00:00

sky_line added the

status

in-progress

label

2026-10-08 02:07:12 +00:00

sky_line referenced this issue from a commit