LL perf (Inventory): `findCategoryUUIDForType` is uncached and is called once per recursion level of every subtree walk #345

New issue

Closed

opened 2026-10-04 14:09:25 +00:00 by sky_line · 1 comment

sky_line commented

2026-10-04 14:09:25 +00:00

Owner

From the LL-origin inefficiency audit (finding I9). File/line references are from commit 0229f8872c; re-locate them before working.

findCategoryUUIDForType is uncached and is called once per recursion level of every subtree walk

Where: llinventorymodel.cpp:884-934, 1288, 1377; llinventoryfilter.cpp:293; llinventoryfunctions.cpp:1094 (LL's comment there: "somewhat expensive... find a way to cache"); llinventorypanel.cpp:727, 900.
Also: findUserDefinedCategoryUUIDForType parses a UUID from a settings string every call (:936).
Fix: per-type cache.
Confirmed. S.

Verify the cost (profile or timer) before and after changing it.

From the LL-origin inefficiency audit (finding I9). File/line references are from commit 0229f8872c; re-locate them before working. **`findCategoryUUIDForType` is uncached and is called once per recursion level of every subtree walk** - **Where:** `llinventorymodel.cpp:884-934, 1288, 1377`; `llinventoryfilter.cpp:293`; `llinventoryfunctions.cpp:1094` (LL's comment there: "somewhat expensive... find a way to cache"); `llinventorypanel.cpp:727, 900`. - **Also:** `findUserDefinedCategoryUUIDForType` parses a UUID from a settings string every call (`:936`). - **Fix:** per-type cache. - Confirmed. S. Verify the cost (profile or timer) before and after changing it.

sky_line added the

perf

label

2026-10-04 14:09:25 +00:00

sky_line added this to the Slipstream project

2026-10-06 15:04:14 +00:00

sky_line added the

status

in-progress

label

2026-10-08 02:07:12 +00:00

sky_line referenced this issue from a commit