sky_line/Slipstream

Fork 1

LL perf (Inventory): Inventory maps are ordered `std::map`/`std::set` keyed by `LLUUID` #346

New issue

Closed

opened 2026-10-04 14:09:25 +00:00 by sky_line · 3 comments

sky_line commented

2026-10-04 14:09:25 +00:00

Owner

From the LL-origin inefficiency audit (finding I10). File/line references are from commit 0229f8872c; re-locate them before working.

Inventory maps are ordered std::map/std::set keyed by LLUUID

Where: llinventorymodel.h:108, 205-218, 719-720.
Lock maps: mCategoryLock[id]/mItemLock[id] operator[] inside llassert_always inserts per folder (.cpp:1692-1712).
Fix: hash maps; move the lock flags into the category object.
Confirmed. M, risk medium.

Verify the cost (profile or timer) before and after changing it.

From the LL-origin inefficiency audit (finding I10). File/line references are from commit 0229f8872c; re-locate them before working. **Inventory maps are ordered `std::map`/`std::set` keyed by `LLUUID`** - **Where:** `llinventorymodel.h:108, 205-218, 719-720`. - **Lock maps:** `mCategoryLock[id]`/`mItemLock[id]` `operator[]` inside `llassert_always` inserts per folder (`.cpp:1692-1712`). - **Fix:** hash maps; move the lock flags into the category object. - Confirmed. M, risk medium. Verify the cost (profile or timer) before and after changing it.

sky_line added the

perf

label

2026-10-04 14:09:25 +00:00

sky_line added this to the Slipstream project

2026-10-06 15:04:13 +00:00

sky_line added the

status

in-progress

label

2026-10-08 02:07:12 +00:00

sky_line removed the

status

in-progress

label

2026-10-09 04:40:58 +00:00

sky_line commented

2026-10-10 05:56:32 +00:00

Author

Owner

No work started yet; back to To Do.

sky_line added the

status

up-next

label

2026-10-10 05:56:32 +00:00

sky_line referenced this issue from a commit

2026-10-10 22:19:25 +00:00

#346: hashed id maps in LLInventoryModel; UUID-ordered iteration where order matters

sky_line referenced this issue from a commit

2026-10-10 22:19:26 +00:00

#346 #350 #353 #358: alt-account test plan for inventory perf round 2

sky_line added

and removed

labels

2026-10-11 16:37:28 +00:00

sky_line commented

2026-10-11 16:37:28 +00:00

Author

Owner

In 1.3.0 Beta 2: the inventory ID maps are now hash maps, with UUID-ordered iteration where order matters.

Moving to testing rather than closing: inventory changes need an alt-account check (copy / move / relog, nothing lost or duplicated) before this is called done.

In 1.3.0 Beta 2: the inventory ID maps are now hash maps, with UUID-ordered iteration where order matters. Moving to testing rather than closing: inventory changes need an alt-account check (copy / move / relog, nothing lost or duplicated) before this is called done.

sky_line commented

2026-10-14 06:33:42 +00:00

Author

Owner

Shipped in 1.3.0 Beta 2 (ebd79bc503 hashed id maps in LLInventoryModel; UUID-ordered iteration where order matters). Closing -- reopen or comment if you still see this.

Shipped in 1.3.0 Beta 2 (ebd79bc503 hashed id maps in LLInventoryModel; UUID-ordered iteration where order matters). Closing -- reopen or comment if you still see this.

sky_line

2026-10-14 06:33:42 +00:00

closed this issue
removed the
status
testing
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

sky_line/Slipstream#346

No description provided.

Rows
Columns

LL perf (Inventory): Inventory maps are ordered std::map/std::set keyed by LLUUID #346

LL perf (Inventory): Inventory maps are ordered `std::map`/`std::set` keyed by `LLUUID` #346