sky_line/Slipstream

Fork 1

LL perf (Inventory): Folder copy is per item #353

New issue

Closed

opened 2026-10-04 14:09:27 +00:00 by sky_line · 3 comments

sky_line commented

2026-10-04 14:09:27 +00:00

Owner

From the LL-origin inefficiency audit (finding I17). File/line references are from commit 0229f8872c; re-locate them before working.

Folder copy is per item

Where: llinventoryfunctions.cpp:482-570; llviewerinventory.cpp:1288-1308.
Per item: one AIS link POST, one CopyInventoryItem, one notifyObservers.
Same pattern: shallowCopyCategoryContents (llappearancemgr.cpp:1970-1981).
Fix: link_inventory_array; multi-block copy.
Confirmed. M.

Verify the cost (profile or timer) before and after changing it.

From the LL-origin inefficiency audit (finding I17). File/line references are from commit 0229f8872c; re-locate them before working. **Folder copy is per item** - **Where:** `llinventoryfunctions.cpp:482-570`; `llviewerinventory.cpp:1288-1308`. - **Per item:** one AIS link POST, one `CopyInventoryItem`, one `notifyObservers`. - **Same pattern:** `shallowCopyCategoryContents` (`llappearancemgr.cpp:1970-1981`). - **Fix:** `link_inventory_array`; multi-block copy. - Confirmed. M. Verify the cost (profile or timer) before and after changing it.

sky_line added the

perf

label

2026-10-04 14:09:27 +00:00

sky_line added this to the Slipstream project

2026-10-06 15:04:13 +00:00

sky_line added the

status

in-progress

label

2026-10-08 02:07:13 +00:00

sky_line removed the

status

in-progress

label

2026-10-09 04:40:58 +00:00

sky_line commented

2026-10-10 05:56:33 +00:00

Author

Owner

No work started yet; back to To Do.

sky_line added the

status

up-next

label

2026-10-10 05:56:33 +00:00

sky_line referenced this issue from a commit

2026-10-10 22:19:26 +00:00

#353: folder copy creates its links in verified link_inventory_array batches

sky_line referenced this issue from a commit

2026-10-10 22:19:26 +00:00

#353: optional multi-block CopyInventoryItem in the copy pacer (default OFF)

sky_line referenced this issue from a commit

2026-10-10 22:19:26 +00:00

#353: one aggregated alert per burst of incomplete link batches

sky_line referenced this issue from a commit

2026-10-10 22:19:26 +00:00

#346 #350 #353 #358: alt-account test plan for inventory perf round 2

sky_line added

and removed

labels

2026-10-11 16:37:29 +00:00

sky_line commented

2026-10-11 16:37:29 +00:00

Author

Owner

Moving to testing rather than closing: inventory changes need an alt-account check (copy / move / relog, nothing lost or duplicated) before this is called done.

In 1.3.0 Beta 2: folder copy now creates its links in verified link_inventory_array batches, with one alert per burst of incomplete batches. The multi-block CopyInventoryItem path is in but off by default until it has had more alt-account testing. Moving to testing rather than closing: inventory changes need an alt-account check (copy / move / relog, nothing lost or duplicated) before this is called done.

sky_line referenced this issue from a commit

2026-10-12 16:50:36 +00:00

#461: InvCreate ledger -- log every inventory create and name the one the server refuses

sky_line commented

2026-10-18 22:26:34 +00:00

Author

Owner

Fixed in Slipstream 1.3.0 (stable): https://git.slipstreamviewer.org/sky_line/Slipstream/releases/tag/v1.3.0

If you still see this on 1.3.0, reply here and we'll reopen it.

Fixed in **Slipstream 1.3.0** (stable): https://git.slipstreamviewer.org/sky_line/Slipstream/releases/tag/v1.3.0 If you still see this on 1.3.0, reply here and we'll reopen it.

sky_line closed this issue

2026-10-18 22:26:34 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

sky_line/Slipstream#353

No description provided.

Rows
Columns