LL perf (Inventory): Small items

sky_line commented

2026-10-04 14:09:28 +00:00

Owner

From the LL-origin inefficiency audit (finding I24). File/line references are from commit 0229f8872c; re-locate them before working.

Small items

updateIsDirty called twice in updateAppearanceFromCOF (llappearancemgr.cpp:2820, 2830); repeated COF and base re-collects (:2686, 3594, 3800).
addChangedMask → update_marketplace_category per change (llinventorymodel.cpp:2342; LL: "probably shouldn't be here").
getBOOL("ChatOnlineNotification") per packet.
Pathfinding floaters re-request the whole list after each action and key by uuid.asString().

Checked and fine:

parcel hover requests (dedupe)
send_agent_update throttle
sendListToRegions batching
multi-object deselect batching
avatar-properties dedupe
region-crossing path
group property throttle

Verify the cost (profile or timer) before and after changing it.

From the LL-origin inefficiency audit (finding I24). File/line references are from commit 0229f8872c; re-locate them before working. **Small items** - `updateIsDirty` called twice in `updateAppearanceFromCOF` (`llappearancemgr.cpp:2820, 2830`); repeated COF and base re-collects (`:2686, 3594, 3800`). - `addChangedMask` → `update_marketplace_category` per change (`llinventorymodel.cpp:2342`; LL: "probably shouldn't be here"). - `getBOOL("ChatOnlineNotification")` per packet. - Pathfinding floaters re-request the whole list after each action and key by `uuid.asString()`. **Checked and fine:** - parcel hover requests (dedupe) - `send_agent_update` throttle - `sendListToRegions` batching - multi-object deselect batching - avatar-properties dedupe - region-crossing path - group property throttle Verify the cost (profile or timer) before and after changing it.

sky_line added the

perf

label

2026-10-04 14:09:28 +00:00

sky_line added this to the Slipstream project

2026-10-06 15:04:13 +00:00

sky_line added the

status

in-progress

label

2026-10-08 02:07:14 +00:00

sky_line removed the

status

in-progress

label

2026-10-09 04:40:59 +00:00

sky_line commented

2026-10-10 05:56:33 +00:00

Author

Owner

No work started yet; back to To Do.

sky_line added the

status

up-next

label

2026-10-10 05:56:33 +00:00

sky_line referenced this issue from a commit

2026-10-10 10:17:52 +00:00

#358: drop the duplicate updateIsDirty() in updateAppearanceFromCOF

sky_line commented

2026-10-10 11:04:13 +00:00

Author

Owner

One item done in 1.3.0 Beta 1 (commit 0ed04437be): removed the duplicate updateIsDirty() in updateAppearanceFromCOF. Skipped for now, all needing profiling or a careful refactor: repeated COF/base re-collects (llappearancemgr.cpp :2686, :3594, :3800), update_marketplace_category in addChangedMask (already cached), and the pathfinding floaters keyed by uuid.asString() (changing the key would change row order).

One item done in 1.3.0 Beta 1 (commit 0ed04437be): removed the duplicate `updateIsDirty()` in `updateAppearanceFromCOF`. Skipped for now, all needing profiling or a careful refactor: repeated COF/base re-collects (llappearancemgr.cpp :2686, :3594, :3800), `update_marketplace_category` in `addChangedMask` (already cached), and the pathfinding floaters keyed by `uuid.asString()` (changing the key would change row order).

sky_line referenced this issue from a commit

2026-10-10 22:19:25 +00:00

#358: ChatOnlineNotification read through a cached control per online/offline packet

sky_line referenced this issue from a commit

2026-10-10 22:19:26 +00:00

#346 #350 #353 #358: alt-account test plan for inventory perf round 2

sky_line removed the

status

up-next

label

2026-10-11 16:37:30 +00:00

sky_line commented

2026-10-11 16:37:30 +00:00

Author

Owner

One item shipped in 1.3.0 Beta 1 (duplicate updateIsDirty removed) and the ChatOnlineNotification lookup is cached in 1.3.0 Beta 2. The rest needs profiling or a careful refactor, so this goes back to the backlog.

sky_line added the

status

up-next

label

2026-10-18 22:22:34 +00:00

Rows
Columns

LL perf (Inventory): Small items #358