LL perf (Core): `LLEventTimer` polled every frame through an allocating snapshot #374

New issue

Closed

opened 2026-10-04 14:09:32 +00:00 by sky_line · 0 comments

sky_line commented

2026-10-04 14:09:32 +00:00

Owner

From the LL-origin inefficiency audit (finding C6). File/line references are from commit 0229f8872c; re-locate them before working.

LLEventTimer polled every frame through an allocating snapshot

Where: lleventtimer.cpp:57-71; llinstancetracker.h:386-415.
Cost: a vector of weak_ptr, then lock plus dynamic_pointer_cast per timer, including every stopped LLFlashTimer owned by flash-enabled buttons (llbutton.cpp:196), chiclets and conversation items. LLToast::updateClass does the same (lltoast.cpp:628).
Fix: min-heap of running timers. LL: believed rewritten in 2024 (LL::Timers); verify.
Confirmed. M.

Verify the cost (profile or timer) before and after changing it.

From the LL-origin inefficiency audit (finding C6). File/line references are from commit 0229f8872c; re-locate them before working. **`LLEventTimer` polled every frame through an allocating snapshot** - **Where:** `lleventtimer.cpp:57-71`; `llinstancetracker.h:386-415`. - **Cost:** a vector of weak_ptr, then lock plus `dynamic_pointer_cast` per timer, including every stopped `LLFlashTimer` owned by flash-enabled buttons (`llbutton.cpp:196`), chiclets and conversation items. `LLToast::updateClass` does the same (`lltoast.cpp:628`). - **Fix:** min-heap of running timers. LL: believed rewritten in 2024 (`LL::Timers`); verify. - Confirmed. M. Verify the cost (profile or timer) before and after changing it.

sky_line added the

perf

label

2026-10-04 14:09:32 +00:00

sky_line added this to the Slipstream project

2026-10-06 15:04:14 +00:00

sky_line added the

status

in-progress

label

2026-10-08 21:19:53 +00:00

sky_line added