LL perf (Core): `LLCallbackList` is a `std::list` with a linear de-dup on add #385

New issue

Closed

opened 2026-10-04 14:09:35 +00:00 by sky_line · 0 comments

sky_line commented

2026-10-04 14:09:35 +00:00

Owner

From the LL-origin inefficiency audit (finding C18). File/line references are from commit 0229f8872c; re-locate them before working.

LLCallbackList is a std::list with a linear de-dup on add

Where: llcallbacklist.cpp:113-120.
Latent bug: a callback deleting the next entry is undefined behaviour. LL: believed rewritten in 2024.
Confirmed. S.

Verify the cost (profile or timer) before and after changing it.

From the LL-origin inefficiency audit (finding C18). File/line references are from commit 0229f8872c; re-locate them before working. **`LLCallbackList` is a `std::list` with a linear de-dup on add** - **Where:** `llcallbacklist.cpp:113-120`. - **Latent bug:** a callback deleting the *next* entry is undefined behaviour. LL: believed rewritten in 2024. - Confirmed. S. Verify the cost (profile or timer) before and after changing it.

sky_line added the

perf

label

2026-10-04 14:09:35 +00:00

sky_line added this to the Slipstream project

2026-10-06 15:04:13 +00:00

sky_line added the

status

testing

label

2026-10-06 15:57:14 +00:00

sky_line referenced this issue from a commit