Octree removal 1: delete dead octree code paths #475

Closed
opened 2026-10-06 09:30:24 +00:00 by sky_line · 1 comment
Owner

Part of #474. From the 2026-10-06 audit: the octrees are still built and maintained every frame, but almost nothing reads them. Rendering, culling, world picking, LOD, texture priority and lights all run on our own systems.

Delete:

  • LLPipeline::lineSegmentIntersectInWorld (pipeline.cpp ~1703-1877), LLSpatialGroup::lineSegmentIntersect (llspatialpartition.cpp ~1282) — no callers.
  • The occluder paths: processOccluders / addOccluders / doOcclusion (llvocache.cpp ~1085-1137). sUseOcclusion is 0 and VK passes do_occlusion=false.
  • LLViewerRegion::killObject (~1817) — no callers.
  • LLSpatialGroup::rebuildGeom / rebuildMesh, the LLVolumeGeometryManager rebuild paths, and the group's mVertexBuffer / mDrawMap remnants.

Restrict: rect-select grow (llglsandbox.cpp ~217-243) to PARTITION_VOLUME + PARTITION_BRIDGE. It already discards every other partition's results.

Part of #474. From the 2026-10-06 audit: the octrees are still built and maintained every frame, but almost nothing reads them. Rendering, culling, world picking, LOD, texture priority and lights all run on our own systems. **Delete:** - `LLPipeline::lineSegmentIntersectInWorld` (pipeline.cpp ~1703-1877), `LLSpatialGroup::lineSegmentIntersect` (llspatialpartition.cpp ~1282) — no callers. - The occluder paths: `processOccluders` / `addOccluders` / `doOcclusion` (llvocache.cpp ~1085-1137). `sUseOcclusion` is 0 and VK passes do_occlusion=false. - `LLViewerRegion::killObject` (~1817) — no callers. - `LLSpatialGroup::rebuildGeom` / `rebuildMesh`, the `LLVolumeGeometryManager` rebuild paths, and the group's `mVertexBuffer` / `mDrawMap` remnants. **Restrict:** rect-select grow (llglsandbox.cpp ~217-243) to `PARTITION_VOLUME` + `PARTITION_BRIDGE`. It already discards every other partition's results.
sky_line added this to the Slipstream project 2026-10-06 15:04:14 +00:00
sky_line referenced this issue from a commit 2026-10-06 20:15:40 +00:00
Author
Owner

Shipped in 1.1.0 Beta 7: octree removal step 1 (the rest continues in #474). Closing; please reopen if anything regressed.

Shipped in **1.1.0 Beta 7**: octree removal step 1 (the rest continues in #474). Closing; please reopen if anything regressed.
sky_line 2026-10-06 21:37:15 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sky_line/Slipstream#475
No description provided.