FX P4: effects in snapshots (custom size, supersampled, 360 policy) #547

New issue

Closed

opened 2026-10-08 06:28:03 +00:00 by sky_line · 1 comment

sky_line commented

2026-10-08 06:28:03 +00:00

Owner

Part of epic #542 (from #186). Design + code citations are in the epic; read it first.

Size: M (2-3 d)

Make FX output match the live view in user snapshots.

Scope

Offscreen recordings (beginOffscreen, llcleanrenderervk.cpp:15439) run the stack at the snapshot size. That requires a recompile (BUFFER_WIDTH/HEIGHT are compile-time) + target re-creation.
- per-size module cache
- warm the compile when the snapshot floater's size changes
- VRAM pre-check; if it doesn't fit, take the shot without FX and say so
Restore live targets after endOffscreen per the generation registry.
screenshot source = true; skip techniques with enabled_in_screenshot = false.
Supersampled shots (#417): run FX only on the last accumulation recording.
360: FX off in v1 (seams). Cel lighting still applies.
Logout screenshot / eyedropper behaviour documented: the eyedropper reads pre-FX linear scene by design (recordScenePixel :26651).

Done when

A 4K / 8K snapshot with a depth effect matches the live view (scaled), and the live view resumes with no stale descriptors.
A supersampled snapshot costs one FX run, not N.
360 capture is unaffected by FX, and the UI says why.

Part of epic #542 (from #186). Design + code citations are in the epic; read it first. **Size:** M (2-3 d) Make FX output match the live view in user snapshots. **Scope** - Offscreen recordings (`beginOffscreen`, `llcleanrenderervk.cpp:15439`) run the stack at the snapshot size. That requires a recompile (BUFFER_WIDTH/HEIGHT are compile-time) + target re-creation. - per-size module cache - warm the compile when the snapshot floater's size changes - VRAM pre-check; if it doesn't fit, take the shot without FX and say so - Restore live targets after `endOffscreen` per the generation registry. - `screenshot` source = true; skip techniques with `enabled_in_screenshot = false`. - **Supersampled shots (#417):** run FX only on the last accumulation recording. - **360:** FX off in v1 (seams). Cel *lighting* still applies. - Logout screenshot / eyedropper behaviour documented: the eyedropper reads pre-FX linear scene by design (`recordScenePixel` :26651). **Done when** - [ ] A 4K / 8K snapshot with a depth effect matches the live view (scaled), and the live view resumes with no stale descriptors. - [ ] A supersampled snapshot costs one FX run, not N. - [ ] 360 capture is unaffected by FX, and the UI says why.

sky_line added the

labels

2026-10-08 06:28:03 +00:00

sky_line added this to the Slipstream project

2026-10-08 06:28:03 +00:00

sky_line referenced this issue

2026-10-08 06:28:04 +00:00

Epic: built-in effects stack (ReShade FX compatible) + cel-shading avatars #542