[GL-B10] Delete the reflection/hero probe managers, LLReflectionMap, lllayeredcubert, LLCubeMapArray #66
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream#66
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Scope: keep a hero-object list in core (VK reads
getHeroList);LLEnvironmentreset/pause/resume calls go awayPrereq: B9, A5
Acceptance: Mirrors work. Environment edits don't crash.
Risk: med
Shared acceptance baseline: links; logs in under VK and renders prims/mesh/rigged/terrain/water/sky/particles; click-select object/avatar/attachment; region crossing + teleport; no
GLSL Compilation Error|SIGSEGVin the log.Source: research/gl_removal_map.md
Status check (verification sweep): partly done. lllayeredcubert is deleted (
21030847b1, v1.0.0-beta.1). Still present as stubs: LLReflectionMapManager (llreflectionmapmanager.cpp, 57 lines), LLHeroProbeManager (60 lines), LLReflectionMap (header), LLCubeMapArray (llrender/llcubemaparray.cpp, stubbed in485bdff4a3). They're still referenced from pipeline.h, llappviewer.cpp, llviewerwindow and llcleanrenderervk.cpp. Remaining: delete them and keep only a core hero-object list.Verified against forgejo/main (v1.2.0,
55f4242518); GL deletion inef8365e45f(gl-delete merge),52c3662a76,547061ef34,5f9502cf69. Verified absent: LLReflectionMap, LLReflectionMapManager, lllayeredcubet, LLCubeMapArray, gPipeline.mReflectionMapManager, LLEnvironment probe reset/pause/resume calls (only RenderSkyAutoAdjustProbeAmbiance setting wiring remains, llenvironment.cpp:902). Kept as specified: hero-object list in core (llheroprobemanager.h:48 getHeroList, read by llappviewer.cpp:4718 for the VK mirror).