[GL-C4] `LLGLEnable`/`LLGLDepthTest`/`LLGLS*` → `LLRender` state scopes

sky_line commented

2026-09-27 05:33:52 +00:00

Owner

Scope: Introduce gGL.pushState-style scopes that take LLRender::CF_*/BT_*. Mechanically convert the 367 newview, 6 llui and 5 llappearance uses (VK-live UI and overlay first; dead files are gone by then).

Prereq: B7–B11

Acceptance: UI, selection overlays, property lines and ban lines render with correct depth

Risk: med

Shared acceptance baseline: links; logs in under VK and renders prims/mesh/rigged/terrain/water/sky/particles; click-select object/avatar/attachment; region crossing + teleport; no GLSL Compilation Error|SIGSEGV in the log.

Source: research/gl_removal_map.md

**Scope:** Introduce `gGL.pushState`-style scopes that take `LLRender::CF_*`/`BT_*`. Mechanically convert the 367 newview, 6 llui and 5 llappearance uses (VK-live UI and overlay first; dead files are gone by then). **Prereq:** B7–B11 **Acceptance:** UI, selection overlays, property lines and ban lines render with correct depth **Risk:** med **Shared acceptance baseline:** links; logs in under VK and renders prims/mesh/rigged/terrain/water/sky/particles; click-select object/avatar/attachment; region crossing + teleport; no `GLSL Compilation Error|SIGSEGV` in the log. Source: research/gl_removal_map.md

sky_line added this to the GL removal C: replace still-needed GL types milestone

2026-09-27 05:33:52 +00:00

sky_line added the

gl-removal

label

2026-09-27 05:33:52 +00:00

sky_line commented

2026-10-04 02:45:47 +00:00

Author

Owner

Status check (verification sweep): not started. There are still 22 LLGLEnable uses (6 files), 91 LLGLDepthTest uses (31 files) and 136 LLGLS* uses (43 files).

sky_line added this to the Slipstream project

2026-10-06 15:04:15 +00:00

sky_line added the

status

up-next

label

2026-10-10 05:06:18 +00:00

sky_line commented

2026-10-10 06:24:39 +00:00

Author

Owner

Verified against forgejo/main: NOT DONE, leaving open. LLGLState-style scopes still exist: ~190 uses of LLGLEnable/LLGLDisable/LLGLDepthTest/LLGLState/LLGLS* remain, with llrender/llgl.h + llglstates.h + llgl.cpp still defining them. Biggest users: fsmaniprotatejoint.cpp (26), llglsandbox.cpp (13), llmaniptranslate.cpp (10), llmanipscale.cpp (8), llmaniprotate.cpp (7), lltoolcomp.cpp (5), lltextureview.cpp (5), fsmaniptranslatejoint.cpp (5), llappearance/lltexlayer.cpp:149,368,369 (5), llmodelpreview.cpp (4), plus ~35 more files with 1-3 each (huds, tracker, world map, parcel overlay, avatar, etc.). No gGL.pushState-style CF_/BT_ scope has replaced them.

Verified against forgejo/main: NOT DONE, leaving open. LLGLState-style scopes still exist: ~190 uses of LLGLEnable/LLGLDisable/LLGLDepthTest/LLGLState/LLGLS* remain, with llrender/llgl.h + llglstates.h + llgl.cpp still defining them. Biggest users: fsmaniprotatejoint.cpp (26), llglsandbox.cpp (13), llmaniptranslate.cpp (10), llmanipscale.cpp (8), llmaniprotate.cpp (7), lltoolcomp.cpp (5), lltextureview.cpp (5), fsmaniptranslatejoint.cpp (5), llappearance/lltexlayer.cpp:149,368,369 (5), llmodelpreview.cpp (4), plus ~35 more files with 1-3 each (huds, tracker, world map, parcel overlay, avatar, etc.). No gGL.pushState-style CF_*/BT_* scope has replaced them.

sky_line referenced this issue from a commit

2026-10-10 09:06:16 +00:00

GL-C4 (#73): LLRender state scopes (StateScope/Blend/Cull/Scissor/Depth/UIScope)

sky_line referenced this issue from a commit

2026-10-10 09:06:16 +00:00

GL-C4 (#73): llui / llappearance onto LLRender::UIScope / DepthScope

sky_line referenced this issue from a commit

2026-10-10 09:06:16 +00:00

GL-C4 (#73): manipulators and edit tools onto LLRender state scopes

sky_line referenced this issue from a commit

2026-10-10 09:06:16 +00:00

GL-C4 (#73): rest of newview onto LLRender state scopes