[GL-C6] Delete LLVertexBuffer, LLRenderTarget, LLCubeMap #75

Closed
opened 2026-09-27 05:33:52 +00:00 by sky_line · 4 comments
Owner

Scope: Move LLVOSky's cube map to a CPU struct or drop it (A-phase waste #10). Move LLRenderSphere to gGL. Snapshots already use the VK swap copy.

Prereq: B11, B13, A7

Acceptance: links; snapshot floater works

Risk: med

Shared acceptance baseline: links; logs in under VK and renders prims/mesh/rigged/terrain/water/sky/particles; click-select object/avatar/attachment; region crossing + teleport; no GLSL Compilation Error|SIGSEGV in the log.

Source: research/gl_removal_map.md

**Scope:** Move `LLVOSky`'s cube map to a CPU struct or drop it (A-phase waste #10). Move `LLRenderSphere` to gGL. Snapshots already use the VK swap copy. **Prereq:** B11, B13, A7 **Acceptance:** links; snapshot floater works **Risk:** med **Shared acceptance baseline:** links; logs in under VK and renders prims/mesh/rigged/terrain/water/sky/particles; click-select object/avatar/attachment; region crossing + teleport; no `GLSL Compilation Error|SIGSEGV` in the log. Source: research/gl_removal_map.md
Author
Owner

Status check (verification sweep): partly done. LLVertexBuffer is a CPU-only geometry container (e7249ecd11), LLRenderTarget is an empty stub (501bfb7244) and LLCubeMap is stubbed (485bdff4a3), all in v1.0.0-beta.1. Remaining: the classes aren't deleted yet. LLVertexBuffer has 177 refs in 22 files (llvertexbuffer.cpp is 700 lines), LLRenderTarget 45 refs in 10 files, LLCubeMap 17 refs in 10 files.

Status check (verification sweep): partly done. LLVertexBuffer is a CPU-only geometry container (e7249ecd11), LLRenderTarget is an empty stub (501bfb7244) and LLCubeMap is stubbed (485bdff4a3), all in v1.0.0-beta.1. Remaining: the classes aren't deleted yet. LLVertexBuffer has 177 refs in 22 files (llvertexbuffer.cpp is 700 lines), LLRenderTarget 45 refs in 10 files, LLCubeMap 17 refs in 10 files.
sky_line added this to the Slipstream project 2026-10-06 15:04:15 +00:00
Author
Owner

Verified against forgejo/main: NOT DONE, leaving open. LLRenderTarget and LLCubeMap are gone, but LLVertexBuffer remains: llrender/llvertexbuffer.{h,cpp} (237-line header), LLVertexBuffer::initClass at llviewerwindow.cpp:2311, users llface.h:216-218,299-300 / llface.cpp:448,1520, llsprite.cpp:189, llvopartgroup.h, llvotree.h, llvovolume.h, llvowater.h, llvoavatar.cpp, llviewerjointmesh.h. LLRenderSphere/gSphere still lives in llrender/llrendersphere.cpp:38 (not moved to gGL).

Verified against forgejo/main: NOT DONE, leaving open. LLRenderTarget and LLCubeMap are gone, but LLVertexBuffer remains: llrender/llvertexbuffer.{h,cpp} (237-line header), LLVertexBuffer::initClass at llviewerwindow.cpp:2311, users llface.h:216-218,299-300 / llface.cpp:448,1520, llsprite.cpp:189, llvopartgroup.h, llvotree.h, llvovolume.h, llvowater.h, llvoavatar.cpp, llviewerjointmesh.h. LLRenderSphere/gSphere still lives in llrender/llrendersphere.cpp:38 (not moved to gGL).
Author
Owner

Pushed to main at 07c8a3ac73. LLVertexBuffer and LLSprite deleted; LLRenderSphere replaced by render_unit_sphere(); LLRenderTarget and LLCubeMap were already gone. To test: Show Light Radius, the rotate manipulator, collision-volume debug.

Pushed to main at 07c8a3ac73. `LLVertexBuffer` and `LLSprite` deleted; `LLRenderSphere` replaced by `render_unit_sphere()`; `LLRenderTarget` and `LLCubeMap` were already gone. To test: Show Light Radius, the rotate manipulator, collision-volume debug.
Author
Owner

Shipped in a published release and tested; closing (testing-lane sweep 2026-10-11).

Shipped in a published release and tested; closing (testing-lane sweep 2026-10-11).
sky_line 2026-10-11 13:24:49 +00:00
Sign in to join this conversation.
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sky_line/Slipstream#75
No description provided.