[GL-E2] Remove dead-only settings #80
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream#80
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Scope: 93 settings are referenced only by pipeline, draw pools, shadermgr or probe files. Examples: all
RenderShadow*biases,RenderSSAO*,RenderGlow*weights,RenderGPUDriven*,RenderCleanWater*debug, DoFCamera*,Preview*lights,Pathfinding*render,RenderShaderCacheVersion,RenderReservedTextureIndices,RenderDelayCreation. Another 281 settings (e.g.RenderUseVAO,RenderUseStreamVBO,RenderVBOMappingDisable,RenderDeferredSun) are referenced nowhere in code. Re-run the classifier after B9–B13. Caveat: the classifier (a word match overnewview/**/*.{cpp,h,xml,py}excludingapp_settings/) treatspipeline.cppas wholly dead despite its live residue, and does not catch keys built dynamically (e.g."Render" + suffix) or per-account settings files. Treat both lists as candidates and grep each key before deleting.Prereq: B9–B13
Acceptance: The viewer starts with an old
settings.xml(unknown keys ignored). Preferences floaters open without warnings.Risk: low
Shared acceptance baseline: links; logs in under VK and renders prims/mesh/rigged/terrain/water/sky/particles; click-select object/avatar/attachment; region crossing + teleport; no
GLSL Compilation Error|SIGSEGVin the log.Source: research/gl_removal_map.md
Status check (verification sweep): partly done. Settings orphaned by the GL removal lanes were dropped (
2375e1a183: 55 dead GL-era settings;3fa9935be6,a0781af458), e.g. RenderShaderCacheVersion, RenderReservedTextureIndices, RenderDelayCreation and RenderGPUDriven* are gone. Still declared in settings.xml: RenderUseVAO, RenderUseStreamVBO, RenderVBOMappingDisable, RenderDeferredSun, RenderSSAOScale, RenderShadowBias, RenderGlowLumWeights, among others. The classifier needs a re-run.Verified against forgejo/main: PARTIAL, leaving open. Done: RenderGPUDriven*, RenderCleanWater*, RenderShaderCacheVersion, RenderReservedTextureIndices, RenderDelayCreation, RenderUseVAO, PathfindingRender* are gone from settings.xml. Remaining (still in indra/newview/app_settings/settings.xml, 11,697 keys total): keys with ZERO code references: RenderUseStreamVBO, RenderVBOMappingDisable, RenderDeferredSun, RenderShadowBias, RenderShadowProjOffset; candidates with only 1-3 word hits (likely dead, grep each): RenderShadowSplitExponent, RenderShadowSlopeThreshold, RenderShadowProjExponent, RenderShadowOffset, RenderShadowGaussian, RenderShadowBlurSize/Samples/DistFactor, RenderSSAOScale/IrradianceScale/IrradianceMax/MaxScale/Factor/Effect, RenderGlowIterations/LumWeights/MaxExtractAlpha/MinLuminance/WarmthAmount/WarmthWeights/Width/Noise (some are live VK tonemap/bloom inputs: RenderGlowStrength, RenderGlowHDR, CameraDoF* verify before deleting), PreviewDiffuse0-2 / PreviewDirection0-2. The classifier was not re-run after B9-B13.
Pushed to main at
07c8a3ac73. Dead GL-only settings removed.Shipped in a published release and tested; closing (testing-lane sweep 2026-10-11).