[GL-E3] Remove GL-only menu items and preference controls #81
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream#81
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Scope:
menu_viewer.xml: Develop > Rendering (:3794), Render Metadata (:3502) and Rendering Features (:2735). That is 19ToggleRenderType, 29ToggleInfoDisplayand 8ToggleFeatureentries plus occlusion items; keep those VK honours (HUD, beacons, selection). Also the graphics preference controls hidden atllfloaterpreferencesgraphicsadvanced.cpp:75, andllviewercontrol.cppGL handlers (handleSetShaderChanged,handleRenderTransparentWaterChanged,handleReleaseGLBufferChanged,createGLBufferscallers).Prereq: B9, E2
Acceptance: All menus open. Each remaining toggle has a visible effect under VK.
Risk: low
Coordinate with #30 / #29: toggles that should work under VK get wired, not deleted.
Shared acceptance baseline: links; logs in under VK and renders prims/mesh/rigged/terrain/water/sky/particles; click-select object/avatar/attachment; region crossing + teleport; no
GLSL Compilation Error|SIGSEGVin the log.Source: research/gl_removal_map.md
Status check (verification sweep): not done. menu_viewer.xml still has 20 ToggleRenderType, 29 ToggleInfoDisplay and 8 ToggleFeature entries. They need auditing against what VK honours (wire or delete, per #29/#30). The llviewercontrol GL handlers are gone (handleSetShaderChanged and handleReleaseGLBufferChanged: 0 refs); one createGLBuffers reference remains.
Verified against forgejo/main: PARTIAL, leaving open. Done: menu_viewer.xml Rendering Types now 12 entries (was 19), Rendering Features 3 (was 8), Render Metadata 8 ToggleInfoDisplay entries (was 29); handleSetShaderChanged and handleReleaseGLBufferChanged are gone; handleRenderTransparentWaterChanged (llviewercontrol.cpp:181) is intentionally kept (VK-live, #521). Remaining GL-only items in Develop > Rendering (menu_viewer.xml): 'Start Debug GL on next run' RenderDebugGLSession (:3869,3872; read at llappviewer.cpp:3292, GL debug context no longer exists), 'Automatic Alpha Masks (non-deferred)' RenderAutoMaskAlphaNonDeferred (:3889,3892; pipeline.cpp:274), and the 'Shadows from Sun/Moon/Projectors'/'SSAO and Shadow Smoothing' RenderDeferredSSAO entries need confirming they act on the VK path. Also not shown that every remaining toggle (Rendering Types/Features/Metadata) has a visible VK effect; llfloaterpreferencesgraphicsadvanced.cpp hidden-control block was not found at the cited line (reworked), please re-check by hand.
Pushed to main at
07c8a3ac73. GL-only menu items and preference controls removed; the validation item is renamed "Enable Vulkan validation on next run".Shipped in a published release and tested; closing (testing-lane sweep 2026-10-11).