Effects: bundle a curated MIT starter pack (SweetFX + prod80) with shipped presets #957

New issue

Closed

opened 2026-10-23 03:06:10 +00:00 by sky_line · 1 comment

sky_line commented

2026-10-23 03:06:10 +00:00

Owner

Follow-up to the effects epic (#542 section 6) and #186, which decided to bundle nothing in v1 and left a curated MIT starter pack for later.

Licensing (from #542, to re-verify at vendoring time)

SweetFX (MIT) and prod80 (MIT): can be bundled with their notices.
ReShade.fxh (CC0) is already shipped; ReShadeUI.fxh is our clean-room copy.
Not bundled: qUINT (all rights reserved), iMMERSE free tier (no redistribution), Lilium HDR (GPL-3, policy choice), crosire reshade-shaders samples (no LICENSE file). These stay user-installed only.

Wanted

Vendor SweetFX and prod80 at a pinned upstream commit (record the commit and source URL). Check the licence of every file at that commit, not just the repo LICENSE: drop any file with a different or missing licence, or bundled textures without clear terms.
Ship only effects that compile and run in our runtime (the #551 compatibility sweep); leave out broken / redundant ones.
Licence notices: the MIT texts in the shipped folder and in About / credits, matching how other third-party code is credited.
Packaging: the bundled effects install into the viewer's built-in effects search path on Linux (tarball, AUR, deb, Flatpak) and Windows (installer), read-only, without overriding a user's own copy of the same effect (user folders win, as today: first folder wins by file name).
A few shipped presets that use only bundled effects (e.g. a subtle colour grade, a film look, sharpening), so a new user gets something useful without installing anything.
Photo Studio's Effects page lists the bundled effects; a user can still add their own packs as now.

Test

Fresh install, no user effects: Effects page shows the bundled effects; each shipped preset loads and renders; no compile errors in the log.
User folder with the same effect file name: the user's copy is used.
About / credits shows the MIT notices.
Packages: effects present in the Linux tarball, deb/AUR/Flatpak and the Windows installer.

Follow-up to the effects epic (#542 section 6) and #186, which decided to bundle nothing in v1 and left a curated MIT starter pack for later. ## Licensing (from #542, to re-verify at vendoring time) - **SweetFX** (MIT) and **prod80** (MIT): can be bundled with their notices. - `ReShade.fxh` (CC0) is already shipped; `ReShadeUI.fxh` is our clean-room copy. - **Not bundled:** qUINT (all rights reserved), iMMERSE free tier (no redistribution), Lilium HDR (GPL-3, policy choice), crosire `reshade-shaders` samples (no LICENSE file). These stay user-installed only. ## Wanted 1. Vendor SweetFX and prod80 at a pinned upstream commit (record the commit and source URL). Check the licence of **every file** at that commit, not just the repo LICENSE: drop any file with a different or missing licence, or bundled textures without clear terms. 2. Ship only effects that compile and run in our runtime (the #551 compatibility sweep); leave out broken / redundant ones. 3. Licence notices: the MIT texts in the shipped folder and in About / credits, matching how other third-party code is credited. 4. Packaging: the bundled effects install into the viewer's built-in effects search path on Linux (tarball, AUR, deb, Flatpak) and Windows (installer), read-only, without overriding a user's own copy of the same effect (user folders win, as today: first folder wins by file name). 5. A few shipped presets that use only bundled effects (e.g. a subtle colour grade, a film look, sharpening), so a new user gets something useful without installing anything. 6. Photo Studio's Effects page lists the bundled effects; a user can still add their own packs as now. ## Test - Fresh install, no user effects: Effects page shows the bundled effects; each shipped preset loads and renders; no compile errors in the log. - User folder with the same effect file name: the user's copy is used. - About / credits shows the MIT notices. - Packages: effects present in the Linux tarball, deb/AUR/Flatpak and the Windows installer.

sky_line added the

feature

label

2026-10-23 03:06:10 +00:00

sky_line added this to the Slipstream project

2026-10-23 03:06:10 +00:00

sky_line referenced this issue from a commit

2026-10-23 04:58:08 +00:00

#957 Effects: bundled MIT starter pack (SweetFX + prod80) and four shipped presets

sky_line referenced this issue from a commit

2026-10-23 06:43:55 +00:00

#957 Effects: bundled MIT starter pack (SweetFX + prod80) and four shipped presets