make windows fails: llappviewerwin32.cpp uses CommandLineToArgvW without shellapi.h #1449

Closed
opened 2026-11-04 20:11:00 +00:00 by TheSlowly · 1 comment
Collaborator

make windows (the clang-cl + xwin cross build, also the release workflow's Windows job) fails on main:

indra/newview/llappviewerwin32.cpp(293,25): error: use of undeclared identifier 'CommandLineToArgvW'

The #1411 pipeline compile worker parses its arguments with CommandLineToArgvW, which shellapi.h declares. The file never includes it, and with WIN32_LEAN_AND_MEAN (set for the whole build) windows.h does not pull it in. Fix: include <shellapi.h> in llappviewerwin32.cpp.

`make windows` (the clang-cl + xwin cross build, also the release workflow's Windows job) fails on main: ``` indra/newview/llappviewerwin32.cpp(293,25): error: use of undeclared identifier 'CommandLineToArgvW' ``` The #1411 pipeline compile worker parses its arguments with `CommandLineToArgvW`, which `shellapi.h` declares. The file never includes it, and with `WIN32_LEAN_AND_MEAN` (set for the whole build) `windows.h` does not pull it in. Fix: include `<shellapi.h>` in llappviewerwin32.cpp.
TheSlowly added this to the Slipstream project 2026-11-04 20:11:00 +00:00
Author
Collaborator

Fixed on main by 6352a0df10.

Fixed on main by 6352a0df10.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sky_line/Slipstream#1449
No description provided.