make windows fails: llappviewerwin32.cpp uses CommandLineToArgvW without shellapi.h #1449
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream#1449
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
make windows(the clang-cl + xwin cross build, also the release workflow's Windows job) fails on main:The #1411 pipeline compile worker parses its arguments with
CommandLineToArgvW, whichshellapi.hdeclares. The file never includes it, and withWIN32_LEAN_AND_MEAN(set for the whole build)windows.hdoes not pull it in. Fix: include<shellapi.h>in llappviewerwin32.cpp.Fixed on main by
6352a0df10.