#1449: llappviewerwin32.cpp includes shellapi.h for CommandLineToArgvW #1450
No reviewers
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream!1450
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "TheSlowly:wincross-shellapi"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1449.
make windows(the cross build, also the release Windows job) stopped at llappviewerwin32.cpp: the #1411 worker calls CommandLineToArgvW, which shellapi.h declares, and WIN32_LEAN_AND_MEAN keeps windows.h from pulling it in. One include; verified with a full localmake windows.Fixed on main by
6352a0df10(the same<shellapi.h>include), so this PR is no longer needed. Closing.Pull request closed