#1449: llappviewerwin32.cpp includes shellapi.h for CommandLineToArgvW #1450

Closed
TheSlowly wants to merge 1 commit from TheSlowly:wincross-shellapi into main
Collaborator

Fixes #1449. make windows (the cross build, also the release Windows job) stopped at llappviewerwin32.cpp: the #1411 worker calls CommandLineToArgvW, which shellapi.h declares, and WIN32_LEAN_AND_MEAN keeps windows.h from pulling it in. One include; verified with a full local make windows.

Fixes #1449. `make windows` (the cross build, also the release Windows job) stopped at llappviewerwin32.cpp: the #1411 worker calls CommandLineToArgvW, which shellapi.h declares, and WIN32_LEAN_AND_MEAN keeps windows.h from pulling it in. One include; verified with a full local `make windows`.
The #1411 pipeline compile worker parses its arguments with
CommandLineToArgvW, which shellapi.h declares. The file never included
it; a build that pulls it in through another header compiles, but the
clang-cl cross build (WIN32_LEAN_AND_MEAN, no precompiled header) stops
with "use of undeclared identifier 'CommandLineToArgvW'".

Test-Plan:
    make windows (wincross) builds llappviewerwin32.cpp again (main fails there with
      "use of undeclared identifier 'CommandLineToArgvW'"); clang-cl /Zs with the build's flags.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Collaborator

Fixed on main by 6352a0df10 (the same <shellapi.h> include), so this PR is no longer needed. Closing.

Fixed on main by 6352a0df10 (the same `<shellapi.h>` include), so this PR is no longer needed. Closing.
TheSlowly closed this pull request 2026-11-05 01:26:54 +00:00

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sky_line/Slipstream!1450
No description provided.