Upload model: the fee never comes back when a part gets no physics hull #1454

New issue

Open

opened 2026-11-05 01:45:45 +00:00 by TheSlowly · 0 comments

TheSlowly commented

2026-11-05 01:45:45 +00:00

Collaborator

Uploading a 53-part model with a physics file: the fee never comes back (Upload fee: TBD, Upload stays disabled), with no error, for as long as the uploader stays open.

The same model in another viewer gets the server's answer in 8 s: MAV_BLOCK_MISSING (physics_convex missing for parts 1 and 14), shown in a popup.

Cause: before asking for the fee, the upload thread waits for the last physics hull job it created (LLMeshUploadThread::generateHulls). A part whose physics triangles are all filtered out gets a job that is never submitted. When that part comes last (parts are ordered by memory address), the job never finishes and the wait never ends. The log shows 51 hulls built for 53 parts.

Fix: only a submitted job can end the wait, so the fee request goes out and the server's error is shown, as in the reference viewer. The model is sent as provided.

Uploading a 53-part model with a physics file: the fee never comes back (Upload fee: TBD, Upload stays disabled), with no error, for as long as the uploader stays open. The same model in another viewer gets the server's answer in 8 s: `MAV_BLOCK_MISSING` (`physics_convex` missing for parts 1 and 14), shown in a popup. Cause: before asking for the fee, the upload thread waits for the last physics hull job it created (`LLMeshUploadThread::generateHulls`). A part whose physics triangles are all filtered out gets a job that is never submitted. When that part comes last (parts are ordered by memory address), the job never finishes and the wait never ends. The log shows 51 hulls built for 53 parts. Fix: only a submitted job can end the wait, so the fee request goes out and the server's error is shown, as in the reference viewer. The model is sent as provided.

TheSlowly added the

labels

2026-11-05 01:45:45 +00:00

TheSlowly self-assigned this

2026-11-05 01:45:45 +00:00

TheSlowly added this to the Slipstream project

2026-11-05 01:45:45 +00:00

TheSlowly referenced this issue from a pull request that will close it,