#1454: Upload model asks for the fee even when a part gets no physics hull #1455
No reviewers
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream!1455
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "TheSlowly/Slipstream:mesh-fee-hang-1454"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1454. Before asking for the fee, the uploader waited for the last physics hull job it created. A part with no usable physics triangles never gets its job submitted, so if that part came last, the wait never ended and the fee stayed TBD. Now only submitted jobs count, so the request goes out and the server's error (e.g. MAV_BLOCK_MISSING) shows as usual. The model is sent as provided.
Before the fee request goes out, the upload thread waits until the last physics hull job it created has finished. The job became "last" in its constructor, before the validity check. A part whose physics triangles are all filtered out is never submitted, so when that part came last (parts are ordered by memory address) the wait never ended: the fee stayed TBD and Upload stayed disabled, with nothing in the log. Only a submitted job now becomes the last one, so the request goes out and the server's reply names the parts it rejects (MAV_BLOCK_MISSING), as in the reference viewer. The model is sent as provided. Test-Plan: python3 indra/newview/tests/mesh_fee_hull_wait_checks.py: FAIL before the fix, OK after clang-cl /Zs (Windows flags) on llmeshrepository.cpp: no errors In world: upload the 53-part model with its physics file; the fee request returns and the MAV_BLOCK_MISSING popup names parts 1 and 14 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.