Bulk mesh uploader: after sorting by LI, clicking a row opens the upload window for the wrong model (the item at that position in name order) #1463
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream#1463
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Bug
In the bulk mesh uploader, after sorting the list by LI (land impact), clicking a row opens the upload window for the wrong item. For example, clicking the top row opens the upload window for the item that was at the top by name, before sorting, not the item that was clicked.
Repro
Expected
Clicking a row opens the window for exactly the model shown in that row, whatever the sort column or order.
Likely cause
The row's position (index) in the displayed list is used to look up the model in the underlying, unsorted array. The row should carry the model's identity (an id or value) instead, and the lookup should use that, or the sorted order should be mapped back.
Code:
llfloatermeshbulkupload.cpp/llmeshbulkupload.cpp(and the scroll list's selection and double-click handlers).