#1463: Bulk mesh uploader acts on the clicked model when the list is sorted #1473

Closed

TheSlowly wants to merge 1 commit from TheSlowly/Slipstream:bulk-mesh-sort-row-1463 into main

TheSlowly commented

2026-11-06 03:47:18 +00:00

Collaborator

Fixes #1463.

Rows were mapped to models by their position in the list, which is wrong once the list is sorted. Each row already carries its model index; every handler (load, remove, skip, physics, LOD, buttons) and the selection restore now use that.

Test: python3 indra/newview/tests/mesh_bulk_sorted_row_checks.py. In world: sort by LI, click rows; each opens the model shown.

Fixes #1463. Rows were mapped to models by their position in the list, which is wrong once the list is sorted. Each row already carries its model index; every handler (load, remove, skip, physics, LOD, buttons) and the selection restore now use that. Test: `python3 indra/newview/tests/mesh_bulk_sorted_row_checks.py`. In world: sort by LI, click rows; each opens the model shown.

TheSlowly added 1 commit

2026-11-06 03:47:18 +00:00

#1463 : Bulk mesh uploader acts on the clicked model when the list is sorted 8d1a0afb79

Every handler (load, remove, skip, set physics, set LOD, clear companions, the
button states) took the selected row's position in the list as its index into
the model list. Once the list was sorted by LI or any other column, that
position pointed at a different model, so clicking the top row opened the model
that was first by name. Each row already carried its model index as its value;
the handlers now read that, and the list restores and moves the selection by
value too, so the highlighted row also stays on the right model.

Test-Plan:
    python3 indra/newview/tests/mesh_bulk_sorted_row_checks.py (fails before, OK after)
    In world: add several models to the bulk mesh uploader, sort by LI, click and
    double-click rows; each opens the model shown in that row. Remove/skip a row
    in sorted order and check the right model changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

TheSlowly commented

2026-11-08 00:23:05 +00:00

Author

Collaborator

Superseded by your fix on main (52315661f0), closing this one. The ticket's still in testing; I'll check your version in world.

Superseded by your fix on main (52315661f0), closing this one. The ticket's still in testing; I'll check your version in world.

TheSlowly closed this pull request

2026-11-08 00:23:05 +00:00

Pull request closed

Please reopen this pull request to perform a merge.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

sky_line/Slipstream!1473

No description provided.

Rows
Columns