Dead graphics controls under Vulkan (Post process quality, Max. nearby lights, Sky, HDR and Emissive...): wire up or remove #423

Closed
opened 2026-10-05 11:03:24 +00:00 by sky_line · 0 comments
Owner

While writing the wiki (#415), several Advanced Graphics controls (Preferences > Graphics > Advanced Settings, floater_preferences_graphics_advanced.xml) turned out not to be read by the Vulkan renderer. They change a setting that nothing uses. The wiki leaves them out for now.

Controls to evaluate

  • Post process quality
  • Max. nearby lights
  • Sky (sky detail)
  • HDR and Emissive

Plus, on the Setup tab, the software update options (LL's updater is compiled out; tracked by the auto-updater ticket). And the performance floater's Automatic adjustments (tracked by the auto-tuner ticket).

For each control, decide

  • Wire it up: make the VK renderer honour it, if it maps to something real in our pipeline and users would want it. For example, max nearby lights → the clustered light count cap; sky detail → sky/atmosphere resolution; post quality → bloom / DoF / AO quality tiers; HDR and emissive → whatever the GL meaning maps to in VK.
  • Or discard it: remove the control from the UI (and the setting from presets / feature tables, keeping #151's "slider only writes visible settings" rule intact) if it has no meaningful VK equivalent.

Also

  • Grep the setting names to confirm there's truly no VK reader (and no indirect path through LL code that feeds a VK uniform).
  • Check the other preference panels (Quick Prefs, Lightbox, performance floater) for the same problem: a control bound to a setting with no VK reader. A small script (XUI control_names → grep for readers in VK / clean code) would find all of them at once.
  • Update the wiki pages (graphics / preferences) to match.

Done when

  • Every Advanced Graphics control either does something under Vulkan or is gone.
  • A one-off audit list of dead controls across all preference panels, each resolved.
While writing the wiki (#415), several **Advanced Graphics** controls (Preferences > Graphics > Advanced Settings, `floater_preferences_graphics_advanced.xml`) turned out **not to be read by the Vulkan renderer**. They change a setting that nothing uses. The wiki leaves them out for now. ## Controls to evaluate - **Post process quality** - **Max. nearby lights** - **Sky** (sky detail) - **HDR and Emissive** Plus, on the **Setup** tab, the **software update options** (LL's updater is compiled out; tracked by the auto-updater ticket). And the performance floater's **Automatic adjustments** (tracked by the auto-tuner ticket). ## For each control, decide - **Wire it up:** make the VK renderer honour it, if it maps to something real in our pipeline and users would want it. For example, max nearby lights → the clustered light count cap; sky detail → sky/atmosphere resolution; post quality → bloom / DoF / AO quality tiers; HDR and emissive → whatever the GL meaning maps to in VK. - **Or discard it:** remove the control from the UI (and the setting from presets / feature tables, keeping #151's "slider only writes visible settings" rule intact) if it has no meaningful VK equivalent. ## Also - Grep the setting names to confirm there's truly no VK reader (and no indirect path through LL code that feeds a VK uniform). - Check the other preference panels (Quick Prefs, Lightbox, performance floater) for the same problem: a control bound to a setting with no VK reader. A small script (XUI `control_name`s → grep for readers in VK / clean code) would find all of them at once. - Update the wiki pages (graphics / preferences) to match. ## Done when - [ ] Every Advanced Graphics control either does something under Vulkan or is gone. - [ ] A one-off audit list of dead controls across all preference panels, each resolved.
sky_line added this to the Slipstream project 2026-10-06 15:04:13 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sky_line/Slipstream#423
No description provided.