#1302 Game controller art: declare the pictures and button icons #1352

Closed

TheSlowly wants to merge 1 commit from TheSlowly/Slipstream:gamecontroller-art-1302 into main

TheSlowly commented

2026-11-01 02:44:54 +00:00

Collaborator

Fixes #1302.

The game controller pictures and button icons were never declared in textures.xml. The diagram asks for them by name (GameControl_Body_*, GameControl_Icon_*), so it fell back to looking them up as bare file names and drew nothing. This happened on every platform, not just Linux.

This adds the 4 pictures and 49 icons, pointing at gamecontrol/*.png. The file names match their case exactly.

Not yet tested in-world.

Fixes #1302. The game controller pictures and button icons were never declared in `textures.xml`. The diagram asks for them by name (`GameControl_Body_*`, `GameControl_Icon_*`), so it fell back to looking them up as bare file names and drew nothing. This happened on every platform, not just Linux. This adds the 4 pictures and 49 icons, pointing at `gamecontrol/*.png`. The file names match their case exactly. Not yet tested in-world.

TheSlowly added 1 commit

2026-11-01 02:44:54 +00:00

#1302 : Game controller pictures and button icons are declared in textures.xml 8cc3234dbc

The controller diagram asks for its art by name (GameControl_Body_<model> and
GameControl_Icon_<family>_<input>, ssgamecontroldiagram.cpp), but none of those names was ever
declared in textures.xml. An undeclared name is looked up as a file name under textures/
("GameControl_Body_xbox" with no folder or extension), which never exists: the viewer logged
"Failed to find local image file" and got a placeholder texture instead of the art. This was not
Linux-only; no platform could find the files. The PNGs were packaged all along.

Declare the 4 controller pictures and the 49 button icons, pointing at gamecontrol/*.png with
names that match the files' exact case.

Test-Plan: Preferences > Game Controllers: the controller picture shows, with a button icon beside
  each callout. Pick each controller style (Xbox, PlayStation 4, Nintendo, Steam Controller): each
  has its own picture and icon set. The Controller overlay window shows the picture too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

TheSlowly commented

2026-11-03 00:02:55 +00:00

Author

Collaborator

Superseded by 50409d0b67 on main; closing.

Superseded by 50409d0b67 on main; closing.

TheSlowly closed this pull request

2026-11-03 00:02:55 +00:00

sky_line commented

2026-11-03 00:27:30 +00:00

Owner

Thanks! This is already on main via the Beta 6 port (50409d0b67 declares the same GameControl_* textures), so merging would declare them twice. Closing as landed.

Thanks! This is already on main via the Beta 6 port (50409d0b67 declares the same GameControl_* textures), so merging would declare them twice. Closing as landed.

Pull request closed

Please reopen this pull request to perform a merge.

No reviewers

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

sky_line/Slipstream!1352

No description provided.

Rows
Columns