#1192: Conference chat: people still listed after a crash can be invited back #1397

Closed

TheSlowly wants to merge 1 commit from TheSlowly/Slipstream:conference-readd-1192 into main

TheSlowly commented

2026-11-02 21:22:56 +00:00

Collaborator

Fixes #1192.

The add-people picker refused anyone still on the conference's participant list, which can stay stale after a crash. Conferences now only refuse yourself; re-inviting someone still present just repeats the invite.

Fixes #1192. The add-people picker refused anyone still on the conference's participant list, which can stay stale after a crash. Conferences now only refuse yourself; re-inviting someone still present just repeats the invite.

TheSlowly added 1 commit

2026-11-02 21:22:56 +00:00

#1192 : Conference chat: people still listed after a crash can be invited back 0620bb633d

The add-people picker (and dropping a person onto the conversation) refused
anyone on the conference's participant list. That list only shrinks when the
server sends a leave notice, so someone who crashed and logged back in could
stay listed for the rest of the session, and there was no way to invite them
back.

A conference now only refuses yourself. Inviting someone who is still in the
conversation just sends them the invite again. P2P chats keep their check.

Test-Plan: Start a conference with two others. Have one of them kill their
  viewer and log back in. Conversation > Add (or drag them from Contacts onto
  the conversation): their name can be chosen, OK is enabled, and they get the
  invite and rejoin. Adding someone who never left works and changes nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

TheSlowly commented

2026-11-03 00:02:54 +00:00

Author

Collaborator

Superseded by 3dc65d085f on main; closing.

Superseded by 3dc65d085f on main; closing.

TheSlowly closed this pull request

2026-11-03 00:02:54 +00:00

sky_line commented

2026-11-03 00:27:30 +00:00

Owner

Thanks! The #1192 fix already landed on main through the Beta 6 port (3dc65d085f, a narrower version that lets a retained, departed speaker be re-invited). This PR also drops the whole already-in-conference check, which would let someone still active be invited twice, so closing it rather than merging. If there's a case the landed fix misses, a small follow-up on current main is welcome.

Thanks! The #1192 fix already landed on main through the Beta 6 port (3dc65d085f, a narrower version that lets a retained, departed speaker be re-invited). This PR also drops the whole already-in-conference check, which would let someone still active be invited twice, so closing it rather than merging. If there's a case the landed fix misses, a small follow-up on current main is welcome.

Pull request closed

Please reopen this pull request to perform a merge.

No reviewers

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

sky_line/Slipstream!1397

No description provided.

Rows
Columns