#1506: Snapshot to disk: the HDR copy option no longer hides behind Save / Cancel #1507

Open

TheSlowly wants to merge 1 commit from TheSlowly/Slipstream:snapshot-hdr-copy-overlap into main

TheSlowly commented

2026-11-09 03:10:27 +00:00

Collaborator

Fixes #1506.

The Disk panel is laid out 380 px tall but shown 276 px tall, so Save / Cancel sit 104 px higher than written and covered "Also save an HDR copy" (HDR displays only). The status line covers the panel's last 16 px, so the buttons can't move down; two gaps above tighten instead and the rows below move up 12 px.

Holdout label shortened to "Also save holdout mattes" (was cut off).
New check snapshot-local-layout lays the panel out at its shown height.

Fixes #1506. The Disk panel is laid out 380 px tall but shown 276 px tall, so Save / Cancel sit 104 px higher than written and covered "Also save an HDR copy" (HDR displays only). The status line covers the panel's last 16 px, so the buttons can't move down; two gaps above tighten instead and the rows below move up 12 px. - Holdout label shortened to "Also save holdout mattes" (was cut off). - New check `snapshot-local-layout` lays the panel out at its shown height.

TheSlowly added 1 commit

2026-11-09 03:10:27 +00:00

#1506 : Snapshot to disk: the HDR copy option no longer hides behind Save / Cancel d88a239221

panel_snapshot_local.xml is laid out 380 px tall but the snapshot floater shows it 276 px tall,
so the bottom-following Save / Cancel buttons sit 104 px higher than written (233..256): "Also
save an HDR copy" (230..246, shown only on an HDR display) was under them and could not be
clicked. The holdout mattes label was also cut off ("...with snapsho"). The floater's status
line is drawn over the panel's last 16 px (260), so the buttons cannot move down.

Two gaps above tighten (Constrain proportions top_pad 12 -> 6, the Name row 6 px closer to the
quality slider's space), so the Name, folder and option rows move up 12 px: the options now end
at 230, over the buttons. The holdout box reads "Also save holdout mattes" like the HDR box.
New check snapshot-local-layout places the panel at its shown height and fails on any option
under the buttons, buttons into the status line, or a check box label wider than its box.

Test-Plan:
    python3 -I scripts/check/run.py --only snapshot-local-layout --only xui
      (snapshot-local-layout failed before on the hidden box and the cut-off label)
    In world on an HDR display: Snapshot > Disk shows both check boxes above Save / Cancel

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u snapshot-hdr-copy-overlap:TheSlowly-snapshot-hdr-copy-overlap

git switch TheSlowly-snapshot-hdr-copy-overlap

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

sky_line/Slipstream!1507

No description provided.

Rows
Columns