#1600: FSR 4 upscaling and frame generation on AMD GPUs #1605
No reviewers
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream!1605
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "TheSlowly/Slipstream:fsr4-1600"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1600: FSR 4.1.2 (ML) upscaling and FSR 4.0.2 frame generation through AMD's FSR SDK 2.4 runtime, with our own FSR 3.1 everywhere else.
Tested: builds; on NVIDIA the DLLs load, the runtime offers only 3.1.6/2.3.4 and FSR falls back to 3.1. Not yet run on AMD. Please try FSR Quality on the 7900 XTX: the log should say "FSR 4 upscaler made". Worth running once with validation layers: AMD's DLLs are closed, so their barriers and view lifetimes (3 present slots) are unverified.
FSR upscaling (RenderVKUpscaler 1-6) now uses AMD's FSR 4.1.2 ML upscaler where the FSR SDK runtime offers it: Windows, Radeon RX 6000 and newer, a recent Adrenalin driver. It is fed by the same inputs pass as our FSR 3.1 (motion, depth, reactive mask, transparency, exposure) and replaces the rest of it. Everywhere else, and for snapshots, offscreen renders and VR, our own FSR 3.1 runs as before; the SDK's 3.1 versions are never used. The runtime is loaded at run time (llcleanffxvk.cpp, the only file that sees the SDK's headers: its Vulkan header declares a VkDeviceContext of its own). FSR 3.1 stays made beside FSR 4, so a refused context or dispatch upscales that same frame with 3.1, and FSR 4 is not tried again until the sizes change. The log says which one runs and why. RenderVKUpscalerFsr4 (A/B, not saved) turns FSR 4 off to compare on the same GPU. Test-Plan: On an RX 6000 / 7000 / 9000 card with Adrenalin 26.10.1 or later, set FSR Quality: the log shows "FSR 4 upscaler made: ..." and the image is sharper and steadier than with RenderVKUpscalerFsr4 0 (FSR 3.1), with no ghosting on moving avatars. Resize the window and change the FSR mode: still FSR 4. Take a snapshot: it still works (FSR 3.1). On NVIDIA / Intel / Linux: "FSR 4 upscaling is not used, FSR 3.1 instead: ..." and FSR looks as before. Test-Settings: RenderVKUpscaler = 2, RenderVKUpscalerFsr4 = 1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>With the FSR generator, frame generation can use AMD's FSR Frame Generation 4.0.2 where the FSR SDK runtime offers it: Windows 11, Radeon RX 9000 and newer, a recent Adrenalin driver. It is dispatched by hand into our own present chain (no SDK swapchain), from the same world, depth and motion images our FSR 3.1 frame generation reads, so pacing, HDR / SDR and the interface layer stay ours. FSR 3.1's images stay made beside it: a refused dispatch generates that frame with 3.1, and FSR 4 is not tried again until the sizes change. Nobody on the team has an RX 9000 card, so this has never run. It is behind RenderVKFrameGenFsr4, off and not saved. That bends the guide's rule that experiment settings are settled before merging; it is deliberate, so the code can be tested once someone has the hardware, and the switch goes (or becomes the default) after that. Test-Plan: Only on an RX 9000 card with Windows 11 and Adrenalin 26.10.1 or later: set RenderVKFrameGenFsr4 on, then turn frame generation on with the FSR generator. The log shows "FSR 4 frame generation made: ..."; generated frames look right while turning the camera and walking, in SDR and HDR, with the interface steady. Anywhere else the log says "FSR 4 frame generation is not used, FSR 3.1 instead: ..." and frame generation works as before. Test-Settings: RenderVKFrameGenFsr4 = 1, RenderVKFrameGenGenerator = 2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Tested on NVIDIA with the final build (all four commits): FSR says "FSR 4 upscaling is not used, FSR 3.1 instead: the device was made without FSR 4's shader features" and FSR 3.1 Quality runs as before (steady frames, clean image, no warnings). FSR 3.1 frame generation also unchanged: generator FSR, 125 of 125 frames generated, 2.00 shown per rendered frame, pacing within 0.54 ms. DLSS and DLSS frame generation unaffected.
Merged into main in
54eb91c942; closing.Pull request closed