#1615: ReSTIR light grid strides its cell xi over the frames #1629

Closed
TheSlowly wants to merge 1 commit from TheSlowly/Slipstream:regir-restir-xi into main
Collaborator

Fixes #1615.

Population 1 of the light grid (the ReSTIR DI set) drew one fresh random xi per cell and frame, so a cell reached by more than R lights swapped its whole slot set, and those lights' shadows, at random every frame. It now steps along the same Kronecker sequence population 0 already uses. RenderVKReSTIRStratifiedXi (default on) keeps the old draw as an A/B.

Ran in-world for two days with no regression. Only cells with more than 16 lights are affected (a busy club); the town scene averaged 3.4 lights per cell, so there it changes nothing.

Fixes #1615. Population 1 of the light grid (the ReSTIR DI set) drew one fresh random xi per cell and frame, so a cell reached by more than R lights swapped its whole slot set, and those lights' shadows, at random every frame. It now steps along the same Kronecker sequence population 0 already uses. RenderVKReSTIRStratifiedXi (default on) keeps the old draw as an A/B. Ran in-world for two days with no regression. Only cells with more than 16 lights are affected (a busy club); the town scene averaged 3.4 lights per cell, so there it changes nothing.
Population 1 (the ReSTIR DI set) drew one fresh random xi per cell and
frame, so a cell reached by more than R lights switched its whole slot
set (and those lights' shadows) at random every frame. Step it along the
same Kronecker sequence population 0 already uses, from its own
rotation. RenderVKReSTIRStratifiedXi (default on) keeps the old draw as
an A/B.
Author
Collaborator

Merged into main in fedb692509; closing.

Merged into main in fedb692509; closing.
TheSlowly closed this pull request 2026-11-22 03:07:43 +00:00

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sky_line/Slipstream!1629
No description provided.