#1615: ReSTIR light grid strides its cell xi over the frames #1629
No reviewers
Labels
No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
sky_line/Slipstream!1629
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "TheSlowly/Slipstream:regir-restir-xi"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #1615.
Population 1 of the light grid (the ReSTIR DI set) drew one fresh random xi per cell and frame, so a cell reached by more than R lights swapped its whole slot set, and those lights' shadows, at random every frame. It now steps along the same Kronecker sequence population 0 already uses. RenderVKReSTIRStratifiedXi (default on) keeps the old draw as an A/B.
Ran in-world for two days with no regression. Only cells with more than 16 lights are affected (a busy club); the town scene averaged 3.4 lights per cell, so there it changes nothing.
Merged into main in
fedb692509; closing.Pull request closed