sky_line/Slipstream
2
3
Fork 1
Code Issues 360 Pull requests 2 Projects 1 Releases 89 Packages Wiki Activity Actions

Restore long-distance camera focus with GPU picking #752

Closed
TheSlowly wants to merge 1 commit from TheSlowly/Slipstream:gpu-camera-focus-distance into main
pull from: TheSlowly/Slipstream:gpu-camera-focus-distance
merge into: sky_line:main
Conversation 1 Commits 1 Files changed 1 +3 -3
TheSlowly commented 2026-10-13 19:52:41 +00:00
Contributor
Copy link

Disabling camera constraints already extended Alt-click focus picking according to render distance. However, the newer GPU picker used a fixed 1,024-metre ray, preventing focus on visible objects farther away.

The fixed 1,024-metre GPU ray was introduced in 2627dbb329 (“#702: GPU raster cursor pick”). It remained in the subsequent #704 picking rewrite, even though the camera-focus code still requested longer distances when constraints were disabled.

This passes the requested distance through to the GPU picker and checks that cached results cover the requested range before reusing them. Normal hover requests retain their existing 1,024-metre range; longer requests are generated only when needed.

Built & tested on Windows

Disabling camera constraints already extended Alt-click focus picking according to render distance. However, the newer GPU picker used a fixed 1,024-metre ray, preventing focus on visible objects farther away. The fixed 1,024-metre GPU ray was introduced in 2627dbb329 (“#702: GPU raster cursor pick”). It remained in the subsequent #704 picking rewrite, even though the camera-focus code still requested longer distances when constraints were disabled. This passes the requested distance through to the GPU picker and checks that cached results cover the requested range before reusing them. Normal hover requests retain their existing 1,024-metre range; longer requests are generated only when needed. Built & tested on Windows
sky_line commented 2026-10-18 02:59:19 +00:00
Owner
Copy link

Already implemented: the GPU pick request covering the full pick ray is in 33ad9b2b02 (on main and release/1.3), so this change is no longer needed. Closing.

Already implemented: the GPU pick request covering the full pick ray is in 33ad9b2b02 (on main and release/1.3), so this change is no longer needed. Closing.
sky_line closed this pull request 2026-10-18 02:59:19 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
amd
AMD / RADV specific

  
avatars
Avatar rendering

  
bug
Something is broken

  
builder
Building / debug views

  
cannot-reproduce
We couldn't reproduce it; needs more info (logs, steps)

  
crash
Crash / hang

  
epic
Large multi-ticket effort; tracks child issues

  
feature
New feature or request

  
from-viewer
Filed from the in-viewer reporter

  
gl-removal
Removing the retired OpenGL pipeline

  
known-limitation
Known limitation, not planned

  
monitoring
Believed fixed; watching for recurrence

  
parity
Feature parity with LL/GL rendering

  
perf
Performance

  
platform
Platform / packaging / ports

  
priority
critical
 Crash, data loss, login or install broken; drop everything

  
priority
high
 Badly broken or blocking for many users; next up

  
priority
low
 Nice to have; when time allows

  
priority
medium
 Should be fixed or done soon

  
provenance
Code provenance: unreleased upstream (Alchemy) code to remove / rebuild independently

  
rendering
Vulkan renderer / visuals

  
rt
Ray tracing

  
status
in-progress
 Actively being worked on (board: In Progress)

  
status
testing
 Fix landed; awaiting verification/testing

  
status
up-next
 Queued to be worked on next (board: To Do)

  
triage
New report, not yet reviewed

  
ui
UI / input / camera

  
upstream
Port from upstream Alchemy/LL

No labels
amd
avatars
bug
builder
cannot-reproduce
crash
epic
feature
from-viewer
gl-removal
known-limitation
monitoring
parity
perf
platform
priority
critical
priority
high
priority
low
priority
medium
provenance
rendering
rt
status
in-progress
status
testing
status
up-next
triage
ui
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
sky_line/Slipstream!752
No description provided.