#1434: Snapshot to Disk remembers the last size used #1476

Open

TheSlowly wants to merge 1 commit from TheSlowly/Slipstream:snapshot-size-1434 into main

TheSlowly commented

2026-11-06 04:33:33 +00:00

Collaborator

Part of #1434 (the size; the blurry 3840x2044 part needs the reporter's snapshot log lines).

The disk panel's resolution list and width/height started from the defaults every time the floater was built. Saving to disk now stores the choice and size (LastSnapshotToDiskSize/Width/Height) and the panel restores them when it's built.

Test: python3 indra/newview/tests/snapshot_disk_size_checks.py. In world: save at 4K, close and reopen the floater (and relog): the size stays.

Part of #1434 (the size; the blurry 3840x2044 part needs the reporter's snapshot log lines). The disk panel's resolution list and width/height started from the defaults every time the floater was built. Saving to disk now stores the choice and size (LastSnapshotToDiskSize/Width/Height) and the panel restores them when it's built. Test: `python3 indra/newview/tests/snapshot_disk_size_checks.py`. In world: save at 4K, close and reopen the floater (and relog): the size stays.

TheSlowly added 1 commit

2026-11-06 04:33:33 +00:00

#1434 : Snapshot to Disk remembers the last size used afa1a6a320

The disk panel's resolution list and width/height spinners started from the
panel's defaults every time the snapshot floater was built, so the size of the
last disk snapshot was lost. Saving to disk now stores the resolution choice
and the size in three settings (LastSnapshotToDiskSize, Width, Height), and the
panel restores them when it is built, before the floater applies them. With
nothing stored yet the defaults stay as before.

Test-Plan:
    python3 indra/newview/tests/snapshot_disk_size_checks.py (fails before, OK after)
    In world: Snapshot > Save to disk at 3840x2160, close the floater, reopen it:
    the size is still 3840x2160. Pick Custom 3000x1500, save, relog: Custom
    3000x1500 is selected. A fresh settings file still opens at the default size.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u snapshot-size-1434:TheSlowly-snapshot-size-1434

git switch TheSlowly-snapshot-size-1434

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

sky_line/Slipstream!1476

No description provided.

Rows
Columns